Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Side by Side Diff: chrome/installer/util/browser_distribution.cc

Issue 11359133: Add default icon to app_host.exe, and use it in shortcuts during installation. (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: More renames and comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // This file defines a class that contains various method related to branding. 5 // This file defines a class that contains various method related to branding.
6 // It provides only default implementations of these methods. Usually to add 6 // It provides only default implementations of these methods. Usually to add
7 // specific branding, we will need to extend this class with a custom 7 // specific branding, we will need to extend this class with a custom
8 // implementation. 8 // implementation.
9 9
10 #include "chrome/installer/util/browser_distribution.h" 10 #include "chrome/installer/util/browser_distribution.h"
(...skipping 207 matching lines...) Expand 10 before | Expand all | Expand 10 after
218 } 218 }
219 219
220 bool BrowserDistribution::CanSetAsDefault() { 220 bool BrowserDistribution::CanSetAsDefault() {
221 return true; 221 return true;
222 } 222 }
223 223
224 bool BrowserDistribution::CanCreateDesktopShortcuts() { 224 bool BrowserDistribution::CanCreateDesktopShortcuts() {
225 return true; 225 return true;
226 } 226 }
227 227
228 string16 BrowserDistribution::GetIconFilename() {
229 return string16();
230 }
231
228 int BrowserDistribution::GetIconIndex() { 232 int BrowserDistribution::GetIconIndex() {
233 // Assuming that main icon appears first alphabetically (e.g., IDR_MAINFRAME).
gab 2012/11/14 21:34:34 What do you think of: ... appears first alphabetic
huangs 2012/11/14 21:57:01 Sounds good. Done.
229 return 0; 234 return 0;
230 } 235 }
231 236
232 bool BrowserDistribution::GetChromeChannel(string16* channel) { 237 bool BrowserDistribution::GetChromeChannel(string16* channel) {
233 return false; 238 return false;
234 } 239 }
235 240
236 bool BrowserDistribution::GetCommandExecuteImplClsid( 241 bool BrowserDistribution::GetCommandExecuteImplClsid(
237 string16* handler_class_uuid) { 242 string16* handler_class_uuid) {
238 if (handler_class_uuid) 243 if (handler_class_uuid)
(...skipping 16 matching lines...) Expand all
255 const Version& version, const installer::Product& product, 260 const Version& version, const installer::Product& product,
256 bool system_level) { 261 bool system_level) {
257 } 262 }
258 263
259 264
260 void BrowserDistribution::InactiveUserToastExperiment(int flavor, 265 void BrowserDistribution::InactiveUserToastExperiment(int flavor,
261 const string16& experiment_group, 266 const string16& experiment_group,
262 const installer::Product& installation, 267 const installer::Product& installation,
263 const FilePath& application_path) { 268 const FilePath& application_path) {
264 } 269 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698