Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/installer/util/browser_distribution.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file declares a class that contains various method related to branding.
 
 #ifndef CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 #define CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_
 
 #include <string>
@@ skipping 103 matching lines @@
   virtual string16 GetUninstallLinkName();
 
   virtual string16 GetUninstallRegPath();
 
   virtual string16 GetVersionKey();
 
   virtual bool CanSetAsDefault();
 
   virtual bool CanCreateDesktopShortcuts();
 
+  virtual string16 GetIconExe();

[gab, 2012/11/13 14:15:12]

I don't really like this new call, I feel if this existed it should return a
full path and since me and grt want to move towards a BrowserDistribution class
that only returns constants I don't like adding this.

The icon index itself is a constant so that's different, the path to the exe is
built differently depending on the state the caller has and I think it should
remain the caller's responsibility to build that path.

At best this could return a constant relative path to the install root, but this
easily becomes confusing to read at the call site imo (I'm thinking system-level
installs where User Data and Application aren't in the same folder) and some
path logic needs to be applied by the caller anyways so I don't really see the
benefit (not even mentioning that the caller will have to make sure the path
they are adding the relative path to is at the correct depth for this relative
path to add up... meh).

[erikwright (departed), 2012/11/13 14:55:34]

Which .exe the icon is in is also constant.
The question is whether the caller has to apply a single path logic for all
cases or whether the caller needs to have an if/else block checking specific
products.

See my other comment in this CL for alternatives.

[grt (UTC plus 2), 2012/11/13 16:19:32]

GetIconExe -> GetIconFile or somesuch, since icons can be in any PE Image file
(.exe or .dll or whatever extension you want).

also, please please please don't follow the terrible precedent of not
documenting methods in this file.

[huangs, 2012/11/13 20:41:54]

I would prefer to have a method to get the full path.  However, chrome_exe is
being passed all over the place in ShellUtils, so some refactor is needed.  What
I have is a compromise to avoid changing too many things.  Pending decisions.

[huangs, 2012/11/13 20:41:54]

Renamed to GetIconFile(), and added comments.

+
   virtual int GetIconIndex();
 
   virtual bool GetChromeChannel(string16* channel);
 
   // Returns true if the distribution includes a DelegateExecute verb handler,
   // and provides the CommandExecuteImpl class UUID if |handler_class_uuid| is
   // non-NULL.
   virtual bool GetCommandExecuteImplClsid(string16* handler_class_uuid);
 
   virtual void UpdateInstallStatus(bool system_install,
@@ skipping 31 matching lines @@
 
   const Type type_;
 
  private:
   BrowserDistribution();
 
   DISALLOW_COPY_AND_ASSIGN(BrowserDistribution);
 };
 
 #endif  // CHROME_INSTALLER_UTIL_BROWSER_DISTRIBUTION_H_