Add default icon to app_host.exe, and use it in shortcuts during installation.

chrome/browser/extensions/app_host/app_host.rc

 // Microsoft Visual C++ generated resource script.
 //
 
 #define APSTUDIO_READONLY_SYMBOLS
 /////////////////////////////////////////////////////////////////////////////
 //
 // Generated from the TEXTINCLUDE 2 resource.
 //
 #define APSTUDIO_HIDDEN_SYMBOLS
 #include "windows.h"
 #undef APSTUDIO_HIDDEN_SYMBOLS
 
 /////////////////////////////////////////////////////////////////////////////
 #undef APSTUDIO_READONLY_SYMBOLS
 
 /////////////////////////////////////////////////////////////////////////////
 // English (U.S.) resources
 
 #if !defined(AFX_RESOURCE_DLL) || defined(AFX_TARG_ENU)
 #ifdef _WIN32
 LANGUAGE LANG_ENGLISH, SUBLANG_ENGLISH_US
 #pragma code_page(1252)
 #endif //_WIN32
 
 /////////////////////////////////////////////////////////////////////////////
 //
+// Icon
+//
+
+// The application icon should: have the lowest ID, be placed first, and its
+// resource name should be alphabetically less than the name of any other icon
+// resource (http://msdn.microsoft.com/en-us/library/ms997538.aspx).
+// Note: chrome/installer/util/shell_util.cc depends on the order and number of
+// icons.  To avoid breaking existing shortcuts, add new icons at the end
+// (following the ordering described above).
+
+// Icon for the App Lancher.
+IDR_MAINFRAME  ICON  "..\\..\\..\\app\\theme\\app_list.ico"

[grt (UTC plus 2), 2012/11/13 16:19:32]

the first field here can either be a name or a uint16 identifier.  in the case
of chrome_dll.rc, IDR_MAINFRAME is a macro that's given the value 101.  that
isn't true in this file, so it ends up being the name of the resource.  there is
no good reason to do this.  i think resource ordering will be more predictable
if you use uint16s.  with that in mind, i suggest you make an
app_host_resources.h file that #defines SOMETHING 101 and then use that
SOMETHING here.  please choose a SOMETHING that's unique to the app host (don't
overload IDR_MAINFRAME any more than it already is).

[grt (UTC plus 2), 2012/11/13 16:19:32]

also, i don't think you need the double-backslashes here.

[huangs, 2012/11/13 20:41:54]

Made the .h file and set name as IDR_APP_HOST_MAIN.

[huangs, 2012/11/13 20:41:54]

The double-backslashes essential.  single-backslash worked for chrome_dll.rc
because \c, \g, and \v happened to be escape characters in C-style string... 
Meanwhile, \a and \t are, and using single-backslash there breaks the build.

[grt (UTC plus 2), 2012/11/14 15:55:14]

Ah, awesome.  Thanks for the clarification.

[huangs, 2012/11/14 17:59:15]

I meant \c, \g, \v are NOT escape characters.

+
+

[benwells, 2012/11/13 05:52:56]

Nit: extra blank line

[huangs, 2012/11/13 20:41:54]

Done.

+/////////////////////////////////////////////////////////////////////////////
+//
 // GOOGLEUPDATEAPPLICATIONCOMMANDS is a "well-known" marker resource defined
 // by Omaha. Executables must both be signed by Google and contain the marker
 // in order to expose application commands.
 //
 #define IDR_GOOGLE_UPDATE_APP_COMMANDS_MARKUP 1
 
 IDR_GOOGLE_UPDATE_APP_COMMANDS_MARKUP GOOGLEUPDATEAPPLICATIONCOMMANDS { 1L }
 
 #endif    // English (U.S.) resources
 /////////////////////////////////////////////////////////////////////////////