Issue 11359125: Rollback of r12868, r12849 on bleeding_edge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359125: Rollback of r12868, r12849 on bleeding_edge. (Closed)

Created:
8 years, 1 month ago by Sven Panne

Modified:
8 years, 1 month ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Rollback of r12868, r12849 on bleeding_edge. Fixed visibility attribute for GetPointerFromInternalField Heavy cleanup of the external pointer API. Committed: https://code.google.com/p/v8/source/detail?r=12911

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+325 lines, -524 lines)			Patch
M	include/v8.h	View	16 chunks	+107 lines, -161 lines	0 comments	Download
M	src/api.h	View	4 chunks	+3 lines, -3 lines	0 comments	Download
M	src/api.cc	View	6 chunks	+134 lines, -116 lines	0 comments	Download
M	src/bootstrapper.cc	View	1 chunk	+2 lines, -3 lines	0 comments	Download
M	src/compiler.cc	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	src/contexts.h	View	3 chunks	+2 lines, -5 lines	0 comments	Download
M	src/factory.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	src/factory.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	src/heap.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	src/heap.cc	View	2 chunks	+0 lines, -22 lines	0 comments	Download
M	src/objects.h	View	2 chunks	+0 lines, -3 lines	0 comments	Download
M	src/objects-inl.h	View	1 chunk	+0 lines, -8 lines	0 comments	Download
M	src/profile-generator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	test/cctest/test-api.cc	View	2 chunks	+0 lines, -96 lines	0 comments	Download
M	test/cctest/test-debug.cc	View	1 chunk	+0 lines, -3 lines	0 comments	Download
M	test/cctest/test-decls.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	tools/grokdump.py	View	1 chunk	+74 lines, -76 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

rubber-stamp LGTM

Expand Messages | Collapse Messages