Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(263)

Issue 11359105: Don't install external extensions in tests (Closed)

Created:
8 years, 1 month ago by Dmitry Polukhin
Modified:
8 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Don't install external extensions in tests BUG=chromium-os:36058 TEST=existing tests passes Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166978

Patch Set 1 #

Patch Set 2 : don't skip policy #

Total comments: 2

Patch Set 3 : comment fixed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M chrome/browser/extensions/default_apps.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/extensions/external_provider_impl.cc View 1 2 2 chunks +15 lines, -9 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
dpolukhin
8 years, 1 month ago (2012-11-09 00:42:29 UTC) #1
zel
lgtm
8 years, 1 month ago (2012-11-09 00:44:16 UTC) #2
Dmitry Polukhin
Mihai, could you please take a look to this CL. I need OWNER review for ...
8 years, 1 month ago (2012-11-09 16:29:42 UTC) #3
Dmitry Polukhin
Antony, I need owner review for extensions files.
8 years, 1 month ago (2012-11-09 16:41:25 UTC) #4
asargent_no_longer_on_chrome
+grv LGTM, but I'd like Gaurav to double-check since he's been doing the most work ...
8 years, 1 month ago (2012-11-09 16:46:53 UTC) #5
Gaurav
LGTM On 2012/11/09 16:46:53, Antony Sargent wrote: > +grv > > LGTM, but I'd like ...
8 years, 1 month ago (2012-11-09 17:34:51 UTC) #6
Gaurav
http://codereview.chromium.org/11359105/diff/3001/chrome/browser/extensions/external_provider_impl.cc File chrome/browser/extensions/external_provider_impl.cc (right): http://codereview.chromium.org/11359105/diff/3001/chrome/browser/extensions/external_provider_impl.cc#newcode327 chrome/browser/extensions/external_provider_impl.cc:327: // In tests don't install extensions from default external ...
8 years, 1 month ago (2012-11-09 17:35:03 UTC) #7
Dmitry Polukhin
http://codereview.chromium.org/11359105/diff/3001/chrome/browser/extensions/external_provider_impl.cc File chrome/browser/extensions/external_provider_impl.cc (right): http://codereview.chromium.org/11359105/diff/3001/chrome/browser/extensions/external_provider_impl.cc#newcode327 chrome/browser/extensions/external_provider_impl.cc:327: // In tests don't install extensions from default external ...
8 years, 1 month ago (2012-11-09 17:49:55 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dpolukhin@chromium.org/11359105/7
8 years, 1 month ago (2012-11-09 17:50:17 UTC) #9
commit-bot: I haz the power
8 years, 1 month ago (2012-11-09 21:41:04 UTC) #10
Change committed as 166978

Powered by Google App Engine
This is Rietveld 408576698