Refactor HTTP parser to hold current buffer

sdk/lib/io/http_impl.dart

Index: sdk/lib/io/http_impl.dart
diff --git a/sdk/lib/io/http_impl.dart b/sdk/lib/io/http_impl.dart
index 19dda9753114bcb68e848777fccd7f9040b2644a..440b635feaa658de76a6114336d35e374c35bfdb 100644
--- a/sdk/lib/io/http_impl.dart
+++ b/sdk/lib/io/http_impl.dart
@@ -1307,15 +1307,7 @@ abstract class _HttpConnectionBase {
     List<int> buffer = new Uint8List(available);
     int bytesRead = _socket.readList(buffer, 0, available);
     if (bytesRead > 0) {
-      int parsed = _httpParser.writeList(buffer, 0, bytesRead);
-      if (!_httpParser.upgrade) {
-        if (parsed != bytesRead) {
-          if (_socket != null) {
-            // TODO(sgjesse): Error handling.
-            _destroy();

[Mads Ager (google), 2012/11/07 13:02:51]

With this change we lose this _destroy call. If we get to the end of parse
without having parsed the entire buffer, we don't do anything now. Should we?

[Søren Gjesse, 2012/11/07 13:31:14]

The parser should always either successfuly parse all data (modulo upgrade) or
report an error. The destruction of the socket here should have resulted in a
onError callback from the HTTP parser.

-          }
-        }
-      }
+      _httpParser.writeList(buffer, 0, bytesRead);
     }
   }
 
@@ -1341,7 +1333,7 @@ abstract class _HttpConnectionBase {
     Socket socket = _socket;
     _socket = null;
     if (onDetach != null) onDetach();
-    return new _DetachedSocket(socket, _httpParser.unparsedData);
+    return new _DetachedSocket(socket, _httpParser.readUnparsedData());
   }
 
   HttpConnectionInfo get connectionInfo {