Refactor HTTP parser to hold current buffer

tests/standalone/io/http_parser_test.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:math';
 import 'dart:scalarlist';
 
 part '../../../sdk/lib/io/http_parser.dart';
 
 class HttpParserTest {
@@ skipping 68 matching lines @@
 
     void testWrite(List<int> requestData, [int chunkSize = -1]) {
       if (chunkSize == -1) chunkSize = requestData.length;
       reset();
       int written = 0;
       int unparsed;
       for (int pos = 0; pos < requestData.length; pos += chunkSize) {
         int remaining = requestData.length - pos;
         int writeLength = min(chunkSize, remaining);
         written += writeLength;
-        int parsed = httpParser.writeList(requestData, pos, writeLength);
-        unparsed = writeLength - parsed;
+        httpParser.writeList(requestData, pos, writeLength);
+        unparsed = httpParser.readUnparsedData().length;
         if (httpParser.upgrade) {
           unparsed += requestData.length - written;
           break;
         } else {
           Expect.equals(0, unparsed);
         }
       }
       Expect.equals(expectedMethod, method);
       Expect.equals(expectedUri, uri);
       Expect.equals(expectedVersion, version);
@@ skipping 25 matching lines @@
       httpParser.error = (e) {
         errorCalled = true;
       };
 
       errorCalled = false;
     }
 
     void testWrite(List<int> requestData, [int chunkSize = -1]) {
       if (chunkSize == -1) chunkSize = requestData.length;
       reset();
-      for (int pos = 0; pos < requestData.length; pos += chunkSize) {
+      for (int pos = 0;
+           pos < requestData.length && !errorCalled;
+           pos += chunkSize) {
         int remaining = requestData.length - pos;
         int writeLength = min(chunkSize, remaining);
         httpParser.writeList(requestData, pos, writeLength);
       }
       Expect.isTrue(errorCalled);
     }
 
     // Test parsing the request three times delivering the data in
     // different chunks.
     List<int> requestData = request.charCodes;
@@ skipping 76 matching lines @@
 
     void testWrite(List<int> requestData, [int chunkSize = -1]) {
       if (chunkSize == -1) chunkSize = requestData.length;
       reset();
       int written = 0;
       int unparsed;
       for (int pos = 0; pos < requestData.length; pos += chunkSize) {
         int remaining = requestData.length - pos;
         int writeLength = min(chunkSize, remaining);
         written += writeLength;
-        int parsed = httpParser.writeList(requestData, pos, writeLength);
-        unparsed = writeLength - parsed;
+        httpParser.writeList(requestData, pos, writeLength);
+        unparsed = httpParser.readUnparsedData().length;
         if (httpParser.upgrade) {
           unparsed += requestData.length - written;
           break;
         } else {
           Expect.equals(0, unparsed);
         }
       }
       if (close) httpParser.connectionClosed();
       Expect.equals(expectedVersion, version);
       Expect.equals(expectedStatusCode, statusCode);
@@ skipping 28 matching lines @@
       httpParser = new _HttpParser();
       httpParser.requestStart = (m, u) => Expect.fail("Expected response");
       httpParser.error = (e) => errorCalled = true;
 
       errorCalled = false;
     }
 
     void testWrite(List<int> requestData, [int chunkSize = -1]) {
       if (chunkSize == -1) chunkSize = requestData.length;
       reset();
-      for (int pos = 0; pos < requestData.length; pos += chunkSize) {
+      for (int pos = 0;
+           pos < requestData.length && !errorCalled;
+           pos += chunkSize) {
         int remaining = requestData.length - pos;
         int writeLength = min(chunkSize, remaining);
         httpParser.writeList(requestData, pos, writeLength);
       }
       if (close) httpParser.connectionClosed();
       Expect.isTrue(errorCalled);
     }
 
     // Test parsing the request three times delivering the data in
     // different chunks.
@@ skipping 543 matching lines @@
 0123456789012345678901234567890\r
 0\r\n\r\n""";
     _testParseInvalidResponse(response);
   }
 }
 
 
 void main() {
   HttpParserTest.runAllTests();
 }