Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Side by Side Diff: chrome/browser/extensions/extension_service.h

Issue 11359081: Lazy initialization for ProcessesEventRouter. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 6 #define CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
7 7
8 #include <list> 8 #include <list>
9 #include <map> 9 #include <map>
10 #include <set> 10 #include <set>
(...skipping 879 matching lines...) Expand 10 before | Expand all | Expand 10 after
890 // Keeps track of app notifications. 890 // Keeps track of app notifications.
891 scoped_refptr<extensions::AppNotificationManager> app_notification_manager_; 891 scoped_refptr<extensions::AppNotificationManager> app_notification_manager_;
892 892
893 // Keeps track of favicon-sized omnibox icons for extensions. 893 // Keeps track of favicon-sized omnibox icons for extensions.
894 ExtensionIconManager omnibox_icon_manager_; 894 ExtensionIconManager omnibox_icon_manager_;
895 ExtensionIconManager omnibox_popup_icon_manager_; 895 ExtensionIconManager omnibox_popup_icon_manager_;
896 896
897 // Flag to make sure event routers are only initialized once. 897 // Flag to make sure event routers are only initialized once.
898 bool event_routers_initialized_; 898 bool event_routers_initialized_;
899 899
900 // TODO(yoz): None of these should be owned by ExtensionService.
901 // crbug.com/159265
Aaron Boodman 2012/11/07 23:51:28 Nit: kill the fancy indenting.
Yoyo Zhou 2012/11/08 00:18:16 Done.
900 scoped_ptr<HistoryExtensionEventRouter> history_event_router_; 902 scoped_ptr<HistoryExtensionEventRouter> history_event_router_;
901 903
902 scoped_ptr<extensions::BrowserEventRouter> browser_event_router_; 904 scoped_ptr<extensions::BrowserEventRouter> browser_event_router_;
903 905
904 scoped_ptr<extensions::WindowEventRouter> window_event_router_; 906 scoped_ptr<extensions::WindowEventRouter> window_event_router_;
905 907
906 scoped_ptr<extensions::PreferenceEventRouter> preference_event_router_; 908 scoped_ptr<extensions::PreferenceEventRouter> preference_event_router_;
907 909
908 scoped_ptr<BookmarkExtensionEventRouter> bookmark_event_router_; 910 scoped_ptr<BookmarkExtensionEventRouter> bookmark_event_router_;
909 911
(...skipping 58 matching lines...) Expand 10 before | Expand all | Expand 10 after
968 #endif 970 #endif
969 971
970 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 972 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
971 InstallAppsWithUnlimtedStorage); 973 InstallAppsWithUnlimtedStorage);
972 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest, 974 FRIEND_TEST_ALL_PREFIXES(ExtensionServiceTest,
973 InstallAppsAndCheckStorageProtection); 975 InstallAppsAndCheckStorageProtection);
974 DISALLOW_COPY_AND_ASSIGN(ExtensionService); 976 DISALLOW_COPY_AND_ASSIGN(ExtensionService);
975 }; 977 };
976 978
977 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_ 979 #endif // CHROME_BROWSER_EXTENSIONS_EXTENSION_SERVICE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698