Chromium Code Reviews Chromium Code Reviews
Issue
11359077:
cc: Replace the WebCore::UnitBezier class with the SkUnitCubicInterp() method from Skia. (Closed)
Descriptioncc: Replace the WebCore::UnitBezier class with the SkUnitCubicInterp() method from Skia.
This method exists in Skia, but is not publicly consumable/linkable with a
component build. Skia will expose this (or a similar) method through a proper
public API, and we should use it. But in the meantime, we make a copy of the
method in timing_function.cc, and use it there in place of WebCore's UnitBezier
class.
Tests:
cc_unittests:TimingFunctionTest.CubicBezierTimingFunction
This test compares the output of the timing function against baseline values
recorded with WebCore's UnitBezier class. If new methods are able to come
closer to those values, we should decrease the epsilon used in the test
accordingly.
R=jamesr
BUG=147395
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=166362
Patch Set 1 #Patch Set 2 : Fix Keyframe test #Patch Set 3 : rebase #
Total comments: 2
Patch Set 4 : Add bug #Patch Set 5 : Fix web unittests #
Messages
Total messages: 5 (0 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
