Issue 11359074: In msys-git-1.7.4, in git-cl $0 is:

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359074: In msys-git-1.7.4, in git-cl $0 is: (Closed)

Created:
8 years, 1 month ago by szager1

Modified:
8 years, 1 month ago

Reviewers:
cmp, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

In msys-git-1.7.4, in git-cl $0 is: C:\depot_tools\/git-cl But in msys-git-1.8.0 it's: C:\depot_tools\\git-cl Handle either syntax correctly. TBR=maruel@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166268

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	git-cl	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

scherkus (not reviewing)

8 years, 1 month ago (2012-11-06 21:46:01 UTC) #3

FYI this broke on Linux with the following message:
./git-cl: line 22: /usr/local/google/scherkus/depot_tools/git-cl/git_cl.py: Not
a directory
./git-cl: line 22: exec:
/usr/local/google/scherkus/depot_tools/git-cl/git_cl.py: cannot execute: Not a
directory

Expand Messages | Collapse Messages