Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(527)

Unified Diff: runtime/vm/flow_graph_compiler.cc

Issue 11359046: For megamorphic calls (IC calls in optimized code), use a stub without attempting to count usage of… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/stub_code.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/flow_graph_compiler.cc
===================================================================
--- runtime/vm/flow_graph_compiler.cc (revision 14493)
+++ runtime/vm/flow_graph_compiler.cc (working copy)
@@ -477,23 +477,27 @@
const ICData& ic_data) {
ASSERT(!ic_data.IsNull());
ASSERT(FLAG_propagate_ic_data || (ic_data.NumberOfChecks() == 0));
- // Because optimized code should not waste time.
- ASSERT(!is_optimizing() || ic_data.num_args_tested() == 1);
const Array& arguments_descriptor =
DartEntry::ArgumentsDescriptor(argument_count, argument_names);
uword label_address = 0;
- switch (ic_data.num_args_tested()) {
- case 1:
- label_address = StubCode::OneArgCheckInlineCacheEntryPoint();
- break;
- case 2:
- label_address = StubCode::TwoArgsCheckInlineCacheEntryPoint();
- break;
- case 3:
- label_address = StubCode::ThreeArgsCheckInlineCacheEntryPoint();
- break;
- default:
- UNIMPLEMENTED();
+ if (is_optimizing()) {
+ // Megamorphic call requires one argument ICData.
+ ASSERT(ic_data.num_args_tested() == 1);
+ label_address = StubCode::MegamorphicCallEntryPoint();
+ } else {
+ switch (ic_data.num_args_tested()) {
+ case 1:
+ label_address = StubCode::OneArgCheckInlineCacheEntryPoint();
+ break;
+ case 2:
+ label_address = StubCode::TwoArgsCheckInlineCacheEntryPoint();
+ break;
+ case 3:
+ label_address = StubCode::ThreeArgsCheckInlineCacheEntryPoint();
+ break;
+ default:
+ UNIMPLEMENTED();
+ }
}
ExternalLabel target_label("InlineCache", label_address);
« no previous file with comments | « no previous file | runtime/vm/stub_code.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698