Issue 11359035: Revert 165605 - Fix branding in chromoting string resources.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11359035: Revert 165605 - Fix branding in chromoting string resources. (Closed)

Created:
8 years, 1 month ago by Hironori Bono

Modified:
8 years, 1 month ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, pam+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 165605 - Fix branding in chromoting string resources. When chromoting resources were converted from messages.json to .grd format incorrect branding was used. Beside that simplified how resources are generated: 1. Now <if> is used to handle branded strings instead of generating grd file in build time 2. Removed resource_ids - ids are now specified in grd files. BUG=158995 Review URL: https://chromiumcodereview.appspot.com/11275101 TBR=sergeyu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=165611

Patch Set 1 #

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+153 lines, -163 lines)			Patch
M	build/grit_action.gypi	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	remoting/base/resources_unittest.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	remoting/grit_action.gypi	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
MM	remoting/remoting.gyp	View	1 chunk	+94 lines, -47 lines	0 comments	Download
M	remoting/resources/common_resources.grd	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	remoting/resources/resource_ids	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	remoting/resources/string_resources.grd	View	8 chunks	+57 lines, -111 lines	0 comments	Download
A +	remoting/tools/remove_official_branding.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages