Adding App Launcher shortcuts on install.

chrome/installer/util/chrome_app_host_distribution.cc

Index: chrome/installer/util/chrome_app_host_distribution.cc
diff --git a/chrome/installer/util/chrome_app_host_distribution.cc b/chrome/installer/util/chrome_app_host_distribution.cc
index 112678e430f84ec1fb76b1c7d2747661fc97bced..436568f62271a8eeb927c37514009b6c5ea648b9 100644
--- a/chrome/installer/util/chrome_app_host_distribution.cc
+++ b/chrome/installer/util/chrome_app_host_distribution.cc
@@ -21,8 +21,11 @@
 #include "installer_util_strings.h"  // NOLINT
 
 namespace {
+
 const wchar_t kChromeAppHostGuid[] = L"{FDA71E6F-AC4C-4a00-8B70-9958A68906BF}";
-}
+const wchar_t kAppListId[] = L"ChromeAppList";

[gab, 2012/11/02 04:19:58]

I don't feel a constant is necessary, I prefer inline below (this only forces
the reader to look up in the file to know what to expect for no added benefit I
feel.

If you really want to keep the constant, at least make it first (i.e. sort them
alphabetically).

[huangs, 2012/11/02 21:05:10]

Keeping the constant, so sorting.  The const is added to maintain consistency
with app_list_controller_win.cc.

+
+}  // namespace
 
 ChromeAppHostDistribution::ChromeAppHostDistribution()
     : BrowserDistribution(CHROME_APP_HOST) {
@@ -48,6 +51,11 @@ string16 ChromeAppHostDistribution::GetAlternateApplicationName() {
   return product_name;
 }
 
+string16 ChromeAppHostDistribution::GetBaseAppId() {
+  // Should be same as AppListController::GetAppModelId().

[erikwright (departed), 2012/11/01 20:43:36]

Note that this will end up being suffixed with a user-specific suffix whereas
the one generated by AppListController seems like it will not end up being
suffixed.

We should make sure that the one generated by AppListController is suffixed in
the exact same way.

I'll follow up with specific instructions there.

[erikwright (departed), 2012/11/02 02:40:27]

I will do a small refactoring of the AppListController that should make it easy
to fix this up properly. In the meantime, you should make sure to
'set_app_model_id' on the ShortcutProperties to the result of calling
ShellUtil::BuildAppModelId() with a vector of components that contains _only_
kAppListId.

[huangs, 2012/11/02 21:05:10]

Done (code is in install.cc: CreateOrUpdateShortcuts()).

+  return kAppListId;
+}
+
 string16 ChromeAppHostDistribution::GetInstallSubDir() {
   return BrowserDistribution::GetSpecificDistribution(
       BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir();
@@ -124,7 +132,7 @@ bool ChromeAppHostDistribution::CanSetAsDefault() {
 }
 
 bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() {
-  return false;
+  return true;
 }
 
 bool ChromeAppHostDistribution::GetCommandExecuteImplClsid(