Adding App Launcher shortcuts on install.

chrome/installer/util/chrome_app_host_distribution.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 //
 // This file defines a specific implementation of BrowserDistribution class for
 // Chrome App Host. It overrides the bare minimum of methods necessary to get a
 // Chrome App Host installer that does not interact with Google Chrome or
 // Chromium installations.
 
 #include "chrome/installer/util/chrome_app_host_distribution.h"
@@ skipping 30 matching lines @@
       installer::GetLocalizedString(IDS_PRODUCT_APP_HOST_NAME_BASE);
   return product_name;
 }
 
 string16 ChromeAppHostDistribution::GetAlternateApplicationName() {
   const string16& product_name =
       installer::GetLocalizedString(IDS_PRODUCT_APP_HOST_NAME_BASE);
   return product_name;
 }
 
+string16 ChromeAppHostDistribution::GetBaseAppId() {
+  // See AppListController::GetAppModelId().
+  return L"ChromeAppList";

[erikwright (departed), 2012/11/01 01:21:50]

Is a TODO required to use the correct App Model ID incorporating the
user-data-dir, right?

[gab, 2012/11/01 04:46:19]

This is the "base AppId", i.e. the one to begin all the appids generated by
other methods. See methods in shell_util.cc; this is correct (compare with
google_chrome_distribution.cc.

[huangs, 2012/11/01 19:20:38]

Expanded comment, and defined constant for this.

+}
+
 string16 ChromeAppHostDistribution::GetInstallSubDir() {
   return BrowserDistribution::GetSpecificDistribution(
       BrowserDistribution::CHROME_BINARIES)->GetInstallSubDir();
 }
 
 string16 ChromeAppHostDistribution::GetPublisherName() {
   const string16& publisher_name =
       installer::GetLocalizedString(IDS_ABOUT_VERSION_COMPANY_NAME_BASE);
   return publisher_name;
 }
@@ skipping 56 matching lines @@
   key.append(L"\\");
   key.append(kChromeAppHostGuid);
   return key;
 }
 
 bool ChromeAppHostDistribution::CanSetAsDefault() {
   return false;
 }
 
 bool ChromeAppHostDistribution::CanCreateDesktopShortcuts() {
-  return false;
+  return true;

[gab, 2012/11/01 04:46:19]

I don't think this has any impact anymore (i.e. fine to change it but we should
add to the installer fixit
(https://docs.google.com/a/google.com/document/d/1Js17FLROy5L83Q8Qp9G6l6hRq1fH...
to either make those have an impact again if they should or remove them (I feel
the latter is correct now))

[huangs, 2012/11/01 19:20:38]

Will edit once I have access.  Planning to add:
- BrowserDistribution::CanCreateDesktopShortcuts() (and overrides) are not
useful now.  Either make it useful or remove it.

 }
 
 bool ChromeAppHostDistribution::GetCommandExecuteImplClsid(
     string16* handler_class_uuid) {
   return false;
 }
 
 void ChromeAppHostDistribution::UpdateInstallStatus(bool system_install,
     installer::ArchiveType archive_type,
     installer::InstallStatus install_status) {
 #if defined(GOOGLE_CHROME_BUILD)
   GoogleUpdateSettings::UpdateInstallStatus(system_install,
       archive_type, InstallUtil::GetInstallReturnCode(install_status),
       kChromeAppHostGuid);
 #endif
 }