Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart

Issue 11359005: Cleanup run on DartDoc tests. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dartdoc/test/dartdoc_search_test.dart » ('j') | pkg/dartdoc/test/markdown_test.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
diff --git a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
index 33ea614c6c676f92530114a875ed4255e85f2267..7523ad65172de3cca5aaa31fb0a6f22f966c1b88 100644
--- a/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
+++ b/pkg/dartdoc/lib/src/mirrors/dart2js_mirror.dart
@@ -420,8 +420,8 @@ abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {
final Element _element;
Dart2JsElementMirror(this.mirrors, this._element) {
- assert (mirrors !== null);
- assert (_element !== null);
+ assert (mirrors != null);
+ assert (_element != null);
}
String get simpleName => _element.name.slowToString();
@@ -494,7 +494,7 @@ abstract class Dart2JsContainerMirror extends Dart2JsElementMirror
Dart2JsContainerMirror(Dart2JsMirrorSystem system, Element element)
: super(system, element);
- abstract void _ensureMembers();
+ void _ensureMembers();
Map<String, MemberMirror> get members {
_ensureMembers();
@@ -761,7 +761,7 @@ class Dart2JsClassMirror extends Dart2JsContainerMirror
SourceLocation get location {
if (_class is PartialClassElement) {
var node = _class.parseNode(mirrors.compiler);
- if (node !== null) {
+ if (node != null) {
var script = _class.getCompilationUnit().script;
var span = mirrors.compiler.spanFromNode(node, script.uri);
return new Dart2JsLocation(script, span);
@@ -925,7 +925,7 @@ class Dart2JsTypedefMirror extends Dart2JsTypeElementMirror
}
TypeMirror get value {
- if (_definition === null) {
+ if (_definition == null) {
// TODO(johnniwinther): Should be [ensureResolved].
mirrors.compiler.resolveTypedef(_typedef.element);
_definition = _convertTypeToTypeMirror(
@@ -1226,7 +1226,7 @@ class Dart2JsFunctionTypeMirror extends Dart2JsTypeElementMirror
}
List<ParameterMirror> get parameters {
- if (_parameters === null) {
+ if (_parameters == null) {
_parameters = _parametersFromFunctionSignature(mirrors, callMethod,
_functionSignature);
}
@@ -1473,7 +1473,7 @@ class Dart2JsFieldMirror extends Dart2JsMemberMirror implements VariableMirror {
SourceLocation get location {
var script = _variable.getCompilationUnit().script;
var node = _variable.variables.parseNode(_diagnosticListener);
- if (node !== null) {
+ if (node != null) {
var span = mirrors.compiler.spanFromNode(node, script.uri);
return new Dart2JsLocation(script, span);
} else {
« no previous file with comments | « no previous file | pkg/dartdoc/test/dartdoc_search_test.dart » ('j') | pkg/dartdoc/test/markdown_test.dart » ('J')

Powered by Google App Engine
This is Rietveld 408576698