core/src/fxcrt/xml_int.h - Issue 1135893008: Re-land: Remove FX_Alloc() null checks now that it can't return NULL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcrt/xml_int.h

Issue 1135893008: Re-land: Remove FX_Alloc() null checks now that it can't return NULL. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: core/src/fxcrt/xml_int.h

diff --git a/core/src/fxcrt/xml_int.h b/core/src/fxcrt/xml_int.h

index 964c7944d178024fe62de2565cb2b97f3b685b17..f0a2485163aed673e0f41af4447b7f455c10ec26 100644

--- a/core/src/fxcrt/xml_int.h

+++ b/core/src/fxcrt/xml_int.h

@@ -107,9 +107,6 @@ public:

m_dwSize = (size_t)FX_MIN(FX_XMLDATASTREAM_BufferSize, nLength - m_nStart);

if (!m_pBuffer) {

m_pBuffer = FX_Alloc(FX_BYTE, m_dwSize);

- if (!m_pBuffer) {

- return FALSE;

- }

}

return m_pFileRead->ReadBlock(m_pBuffer, m_nStart, m_dwSize);

}

« no previous file with comments | « core/src/fxcrt/fxcrt_posix.cpp ('k') | core/src/fxge/agg/agg23/agg_array.h » ('j') | no next file with comments »