Re-land: Remove FX_Alloc() null checks now that it can't return NULL.

core/src/fxge/win32/fx_win32_gdipext.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../include/fxge/fx_ge.h"
 #if _FX_OS_ == _FX_WIN32_DESKTOP_ || _FX_OS_ == _FX_WIN64_
 #include <windows.h>
 #include <algorithm>
@@ skipping 748 matching lines @@
         case CFX_GraphStateData::LineJoinRound:
             lineJoin = LineJoinRound;
             break;
         case CFX_GraphStateData::LineJoinBevel:
             lineJoin = LineJoinBevel;
             break;
     }
     CallFunc(GdipSetPenLineJoin)(pPen, lineJoin);
     if(pGraphState->m_DashCount) {
         FX_FLOAT* pDashArray = FX_Alloc(FX_FLOAT, pGraphState->m_DashCount + pGraphState->m_DashCount % 2);
-        if (!pDashArray) {
-            return NULL;
-        }
         int nCount = 0;
         FX_FLOAT on_leftover = 0, off_leftover = 0;
         for (int i = 0; i < pGraphState->m_DashCount; i += 2) {
             FX_FLOAT on_phase = pGraphState->m_DashArray[i];
             FX_FLOAT off_phase;
             if (i == pGraphState->m_DashCount - 1) {
                 off_phase = on_phase;
             } else {
                 off_phase = pGraphState->m_DashArray[i + 1];
             }
@@ skipping 81 matching lines @@
     CGdiplusExt& GdiplusExt = ((CWin32Platform*)CFX_GEModule::Get()->GetPlatformData())->m_GdiplusExt;
     CallFunc(GdipCreateFromHDC)(hDC, &pGraphics);
     CallFunc(GdipSetPageUnit)(pGraphics, UnitPixel);
     CallFunc(GdipSetPixelOffsetMode)(pGraphics, PixelOffsetModeHalf);
     GpMatrix* pMatrix = NULL;
     if (pObject2Device) {
         CallFunc(GdipCreateMatrix2)(pObject2Device->a, pObject2Device->b, pObject2Device->c, pObject2Device->d, pObject2Device->e, pObject2Device->f, &pMatrix);
         CallFunc(GdipSetWorldTransform)(pGraphics, pMatrix);
     }
     PointF *points = FX_Alloc(PointF, nPoints);
-    if (!points) {
-        return FALSE;
-    }
     BYTE * types  = FX_Alloc(BYTE, nPoints);
-    if (!types) {
-        FX_Free(points);
-        return FALSE;
-    }
     int nSubPathes = 0;
     FX_BOOL bSubClose = FALSE;
     int pos_subclose = 0;
     FX_BOOL bSmooth = FALSE;
     int startpoint = 0;
     for(int i = 0; i < nPoints; i++) {
         points[i].X = pPoints[i].m_PointX;
         points[i].Y = pPoints[i].m_PointY;
         FX_FLOAT x, y;
         if (pObject2Device) {
@@ skipping 294 matching lines @@
         dest_pixel_format = PixelFormat1bppIndexed;
     } else if (pixel_format == PixelFormat8bppIndexed) {
         info_size += 1024;
         bpp = 8;
         dest_pixel_format = PixelFormat8bppIndexed;
     } else if (pixel_format == PixelFormat32bppARGB) {
         bpp = 32;
         dest_pixel_format = PixelFormat32bppARGB;
     }
     LPBYTE buf = FX_Alloc(BYTE, info_size);
-    if (!buf) {
-        if (pStream) {
-            pStream->Release();
-        }
-        return NULL;
-    }
     BITMAPINFOHEADER* pbmih = (BITMAPINFOHEADER*)buf;
     pbmih->biBitCount = bpp;
     pbmih->biCompression = BI_RGB;
     pbmih->biHeight = -(int)height;
     pbmih->biPlanes = 1;
     pbmih->biWidth = width;
     Rect rect(0, 0, width, height);
     BitmapData* pBitmapData = FX_Alloc(BitmapData, 1);
-    if (!pBitmapData) {
-        if (pStream) {
-            pStream->Release();
-        }
-        return NULL;
-    }
     CallFunc(GdipBitmapLockBits)(pBitmap, &rect, ImageLockModeRead,
                                  dest_pixel_format, pBitmapData);
     if (pixel_format == PixelFormat1bppIndexed || pixel_format == PixelFormat8bppIndexed) {
         DWORD* ppal = (DWORD*)(buf + sizeof(BITMAPINFOHEADER));
         struct {
             UINT flags;
             UINT Count;
             DWORD Entries[256];
         } pal;
         int size = 0;
         CallFunc(GdipGetImagePaletteSize)(pBitmap, &size);
         CallFunc(GdipGetImagePalette)(pBitmap, (ColorPalette*)&pal, size);
         int entries = pixel_format == PixelFormat1bppIndexed ? 2 : 256;
         for (int i = 0; i < entries; i ++) {
             ppal[i] = pal.Entries[i] & 0x00ffffff;
         }
     }
     PREVIEW3_DIBITMAP* pInfo = FX_Alloc(PREVIEW3_DIBITMAP, 1);
-    if (!pInfo) {
-        if (pStream) {
-            pStream->Release();
-        }
-        return NULL;
-    }
     pInfo->pbmi = (BITMAPINFO*)buf;
     pInfo->pScan0 = (LPBYTE)pBitmapData->Scan0;
     pInfo->Stride = pBitmapData->Stride;
     pInfo->pBitmap = pBitmap;
     pInfo->pBitmapData = pBitmapData;
     pInfo->pStream = pStream;
     return pInfo;
 }
 static void FreeDIBitmap(PREVIEW3_DIBITMAP* pInfo)
 {
@@ skipping 24 matching lines @@
         for (int i = 0; i < height; i ++) {
             FXSYS_memcpy32(pData + dest_pitch * i, pInfo->pScan0 + pInfo->Stride * i, dest_pitch);
         }
     }
     CFX_DIBitmap* pDIBitmap = _FX_WindowsDIB_LoadFromBuf(pInfo->pbmi, pData, pInfo->pbmi->bmiHeader.biBitCount == 32);
     FX_Free(pData);
     FreeDIBitmap(pInfo);
     return pDIBitmap;
 }
 #endif