Re-land: Remove FX_Alloc() null checks now that it can't return NULL.

core/src/fpdfdoc/doc_annot.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
  
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "../../../third_party/base/nonstd_unique_ptr.h"
 #include "../../include/fpdfdoc/fpdf_doc.h"
 #include "../../include/fpdfapi/fpdf_pageobj.h"
 
@@ skipping 321 matching lines @@
     pColorData->m_StrokeRGB = argb;
     pPathObject->m_bStroke = TRUE;
     pPathObject->m_FillType = 0;
     if (style_char == 'D') {
         if (pDashArray) {
             FX_DWORD dash_count = pDashArray->GetCount();
             if (dash_count % 2) {
                 dash_count ++;
             }
             pGraphState->m_DashArray = FX_Alloc(FX_FLOAT, dash_count);
-            if (pGraphState->m_DashArray == NULL) {
-                return NULL;
-            }
             pGraphState->m_DashCount = dash_count;
             FX_DWORD i;
             for (i = 0; i < pDashArray->GetCount(); i ++) {
                 pGraphState->m_DashArray[i] = pDashArray->GetNumber(i);
             }
             if (i < dash_count) {
                 pGraphState->m_DashArray[i] = pGraphState->m_DashArray[i - 1];
             }
         } else {
             pGraphState->m_DashArray = FX_Alloc(FX_FLOAT, 2);
-            if (pGraphState->m_DashArray == NULL) {
-                return NULL;
-            }
             pGraphState->m_DashCount = 2;
             pGraphState->m_DashArray[0] = pGraphState->m_DashArray[1] = 3 * 1.0f;
         }
     }
     CFX_FloatRect rect;
     GetRect(rect);
     width /= 2;
     CPDF_PathData *pPathData = pPathObject->m_Path.GetModify();
     if (pPathData) {
         pPathData->AppendRect(rect.left + width, rect.bottom + width, rect.right - width, rect.top - width);
@@ skipping 66 matching lines @@
     }
     CPDF_GraphStateData graph_state;
     graph_state.m_LineWidth = width;
     if (style_char == 'D') {
         if (pDashArray) {
             FX_DWORD dash_count = pDashArray->GetCount();
             if (dash_count % 2) {
                 dash_count ++;
             }
             graph_state.m_DashArray = FX_Alloc(FX_FLOAT, dash_count);
-            if (graph_state.m_DashArray == NULL) {
-                return ;
-            }
             graph_state.m_DashCount = dash_count;
             FX_DWORD i;
             for (i = 0; i < pDashArray->GetCount(); i ++) {
                 graph_state.m_DashArray[i] = pDashArray->GetNumber(i);
             }
             if (i < dash_count) {
                 graph_state.m_DashArray[i] = graph_state.m_DashArray[i - 1];
             }
         } else {
             graph_state.m_DashArray = FX_Alloc(FX_FLOAT, 2);
-            if (graph_state.m_DashArray == NULL) {
-                return ;
-            }
             graph_state.m_DashCount = 2;
             graph_state.m_DashArray[0] = graph_state.m_DashArray[1] = 3 * 1.0f;
         }
     }
     CFX_FloatRect rect;
     GetRect(rect);
     CPDF_PathData path;
     width /= 2;
     path.AppendRect(rect.left + width, rect.bottom + width, rect.right - width, rect.top - width);
     int fill_type = 0;
@@ skipping 30 matching lines @@
         if (pIRT != m_pAnnotDict) {
             continue;
         }
         if (count == index) {
             return pAnnot;
         }
         count ++;
     }
     return NULL;
 }