Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(598)

Unified Diff: lib/src/codegen/js_codegen.dart

Issue 1135883004: Make typedefs lazy again (Closed) Base URL: git@github.com:dart-lang/dev_compiler.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: lib/src/codegen/js_codegen.dart
diff --git a/lib/src/codegen/js_codegen.dart b/lib/src/codegen/js_codegen.dart
index 31400493aad53d6698c6cd828f6d15dabe0d7a0f..9c4bf292abbfeaacfd7358bd893ad7b58acb9dfa 100644
--- a/lib/src/codegen/js_codegen.dart
+++ b/lib/src/codegen/js_codegen.dart
@@ -282,13 +282,11 @@ class JSCodegenVisitor extends GeneralizingAstVisitor with ConversionVisitor {
var type = element.type;
var name = element.name;
- _loader.startTopLevel(element);
- var fnType = js.statement('let # = dart.typedef(#, #);', [
+ var fnType = js.statement('let # = dart.typedef(#, () => #);', [
name,
js.string(name, "'"),
_emitTypeName(type, lowerTypedef: true)
]);
- _loader.finishTopLevel(element);
return _finishClassDef(type, fnType);
}

Powered by Google App Engine
This is Rietveld 408576698