Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(372)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135883004: Make typedefs lazy again (Closed)

Created:
5 years, 7 months ago by Jennifer Messerly
Modified:
5 years, 7 months ago
Reviewers:
vsm
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make typedefs lazy again reverts part of https://github.com/dart-lang/dev_compiler/commit/3dcea8bf156b3947c4dbf4b36da55a64cd9dc492 On its own, it's probably okay, but trips on other issues we have w.r.t. JsName types and NoInterfaceObject apis R=vsm@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/ec42b578b95874af873e6207824845955ecc3b48

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+231 lines, -192 lines) Patch
M lib/runtime/dart/_internal.js View 4 chunks +7 lines, -7 lines 0 comments Download
M lib/runtime/dart/_isolate_helper.js View 2 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/_js_helper.js View 3 chunks +4 lines, -4 lines 0 comments Download
M lib/runtime/dart/async.js View 25 chunks +102 lines, -102 lines 0 comments Download
M lib/runtime/dart/collection.js View 3 chunks +5 lines, -5 lines 0 comments Download
M lib/runtime/dart/convert.js View 4 chunks +7 lines, -7 lines 0 comments Download
M lib/runtime/dart/core.js View 6 chunks +43 lines, -43 lines 0 comments Download
M lib/runtime/dart_runtime.js View 1 5 chunks +56 lines, -15 lines 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 chunk +1 line, -3 lines 0 comments Download
M test/codegen/expect/sunflower/dom.js View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
Jennifer Messerly
5 years, 7 months ago (2015-05-14 16:13:43 UTC) #2
vsm
lgtm https://codereview.chromium.org/1135883004/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1135883004/diff/1/lib/runtime/dart_runtime.js#newcode507 lib/runtime/dart_runtime.js:507: return isClassSubType(type, core.Function) || type instanceof AbstractFunctionType; nit: ...
5 years, 7 months ago (2015-05-14 16:16:33 UTC) #3
Jennifer Messerly
https://codereview.chromium.org/1135883004/diff/1/lib/runtime/dart_runtime.js File lib/runtime/dart_runtime.js (right): https://codereview.chromium.org/1135883004/diff/1/lib/runtime/dart_runtime.js#newcode507 lib/runtime/dart_runtime.js:507: return isClassSubType(type, core.Function) || type instanceof AbstractFunctionType; On 2015/05/14 ...
5 years, 7 months ago (2015-05-14 16:30:18 UTC) #4
Jennifer Messerly
5 years, 7 months ago (2015-05-14 16:45:45 UTC) #5
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
ec42b578b95874af873e6207824845955ecc3b48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698