Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1135863003: [Android] Remove isolate_deps_dir after files have been pushed. (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
Reviewers:
perezju, newt (away)
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org, jbudorick+watch_chromium.org, rnephew (Reviews Here), mikecase (-- gone --)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Android] Remove isolate_deps_dir after files have been pushed. The old test runner leaves isolate_deps_dir around while running tests. gtests remove it at the end of a test run, but instrumentation tests do not. This CL makes both test types remove isolate_deps_dir immediately after pushing the data dependencies to the device. BUG= Committed: https://crrev.com/e9bc362d18529975c5e80193fa2e118fc1acadcf Cr-Commit-Position: refs/heads/master@{#329152}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -5 lines) Patch
M build/android/pylib/base/base_setup.py View 2 chunks +3 lines, -0 lines 0 comments Download
M build/android/pylib/gtest/setup.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/pylib/instrumentation/setup.py View 2 chunks +3 lines, -1 line 0 comments Download
M build/android/test_runner.py View 1 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
jbudorick
5 years, 7 months ago (2015-05-08 22:01:17 UTC) #2
jbudorick
5 years, 7 months ago (2015-05-09 00:20:40 UTC) #4
perezju
lgtm
5 years, 7 months ago (2015-05-11 09:06:03 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135863003/20001
5 years, 7 months ago (2015-05-11 13:03:52 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-11 14:21:59 UTC) #8
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/e9bc362d18529975c5e80193fa2e118fc1acadcf Cr-Commit-Position: refs/heads/master@{#329152}
5 years, 7 months ago (2015-05-11 14:22:44 UTC) #9
newt (away)
5 years, 7 months ago (2015-05-11 15:48:40 UTC) #10
Message was sent while issue was closed.
thanks for fixing this :)

Powered by Google App Engine
This is Rietveld 408576698