Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1135853003: Call Python version of oilplan plugin flags script. (Closed)

Created:
5 years, 7 months ago by Nico
Modified:
5 years, 3 months ago
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Call Python version of oilplan plugin flags script. Also do this on Windows if blink_gc_plugin is set (which it isn't by default, so no behavior change). Depends on https://codereview.chromium.org/1137873002/ BUG=467287 R=sigbjornf@opera.com TBR=jochen Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195155

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -3 lines) Patch
M Source/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M Source/config.gyp View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Nico
5 years, 7 months ago (2015-05-08 23:55:44 UTC) #2
sof
lgtm (non-owner, but oilpan plugin contributor.)
5 years, 7 months ago (2015-05-09 20:21:46 UTC) #4
Nico
tbr jochen for Source/OWNERS
5 years, 7 months ago (2015-05-09 20:26:18 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135853003/1
5 years, 7 months ago (2015-05-09 20:26:37 UTC) #8
Nico
Committed patchset #1 (id:1) manually as 195155 (presubmit successful).
5 years, 7 months ago (2015-05-09 22:42:36 UTC) #9
hans
5 years, 7 months ago (2015-05-11 17:57:24 UTC) #10
Message was sent while issue was closed.
lgtm too

Powered by Google App Engine
This is Rietveld 408576698