Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1135833004: Remove now unused DelayedSocketData (Closed)

Created:
5 years, 7 months ago by Ryan Hamilton
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, mmenke
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove now unused DelayedSocketData. Committed: https://crrev.com/ffe8aa320fbd14e9f7defec899cf0f18565b9c15 Cr-Commit-Position: refs/heads/master@{#330852}

Patch Set 1 #

Patch Set 2 : Done #

Patch Set 3 : Rebase #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -110 lines) Patch
M net/socket/socket_test_util.h View 1 2 3 1 chunk +0 lines, -48 lines 0 comments Download
M net/socket/socket_test_util.cc View 1 2 3 1 chunk +0 lines, -62 lines 0 comments Download

Messages

Total messages: 17 (8 generated)
Ryan Hamilton
5 years, 7 months ago (2015-05-16 19:21:09 UTC) #2
ramant (doing other things)
lgtm
5 years, 7 months ago (2015-05-17 04:45:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135833004/20001
5 years, 7 months ago (2015-05-17 04:50:02 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/25915)
5 years, 7 months ago (2015-05-17 04:52:32 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135833004/40001
5 years, 7 months ago (2015-05-17 04:59:08 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/73003)
5 years, 7 months ago (2015-05-17 05:10:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135833004/60001
5 years, 7 months ago (2015-05-20 22:20:45 UTC) #15
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 7 months ago (2015-05-20 23:52:35 UTC) #16
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 23:53:39 UTC) #17
Message was sent while issue was closed. 
Patchset 4 (id:??) landed as
https://crrev.com/ffe8aa320fbd14e9f7defec899cf0f18565b9c15
Cr-Commit-Position: refs/heads/master@{#330852}

Powered by Google App Engine
This is Rietveld 408576698