cc: Ensure pending tree needs prop updates when active tree scrolls.

cc: Ensure pending tree needs prop updates when active tree scrolls.

This patch ensures that the pending layer is informed of scroll
updates that happen on the active tree. That way the information
can propagate down to wherever it is used (such as tilings)

BUG=483638
R=aelias, enne

Committed: https://crrev.com/e8624082aaf1743e46f2868f807ac164c587d77b
Cr-Commit-Position: refs/heads/master@{#329232}

[aelias_OOO_until_Jul13, 2015-05-08 21:44:00]

aelias@chromium.org changed reviewers:
+ aelias@chromium.org

[aelias_OOO_until_Jul13, 2015-05-08 21:44:00]

https://codereview.chromium.org/1135833002/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1135833002/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:1228: pending_twin->ScrollbarParametersDidChange(false);
I don't think this line is needed, pending tree scrollbars aren't relevant.

[enne (OOO), 2015-05-08 22:09:16]

Can you add a unit test that scrolling the active tree marks the pending tree as
needing an update, and updates visible rects appropriately when called?

[vmpstr, 2015-05-11 18:35:39]

vmpstr@chromium.org changed reviewers:
+ enne@chromium.org

[vmpstr, 2015-05-11 18:36:16]

Please take a look.

https://codereview.chromium.org/1135833002/diff/1/cc/layers/layer_impl.cc
File cc/layers/layer_impl.cc (right):

https://codereview.chromium.org/1135833002/diff/1/cc/layers/layer_impl.cc#new...
cc/layers/layer_impl.cc:1228: pending_twin->ScrollbarParametersDidChange(false);
On 2015/05/08 21:44:00, aelias wrote:
> I don't think this line is needed, pending tree scrollbars aren't relevant.

Removed.

https://codereview.chromium.org/1135833002/diff/20001/cc/layers/picture_layer...
File cc/layers/picture_layer_impl_unittest.cc (right):

https://codereview.chromium.org/1135833002/diff/20001/cc/layers/picture_layer...
cc/layers/picture_layer_impl_unittest.cc:4954: EXPECT_EQ("0,50 100x100",
pending_layer_->HighResTiling()
This part fails without the patch, and passes with the patch.

[enne (OOO), 2015-05-11 18:47:50]

lgtm

[vmpstr, 2015-05-11 18:56:16]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-05-11 18:57:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135833002/20001

[commit-bot: I haz the power, 2015-05-11 19:07:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:07:01]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2015-05-11 19:29:23]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:30:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135833002/20001

[commit-bot: I haz the power, 2015-05-11 19:36:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-11 19:36:14]

Try jobs failed on following builders:
  linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[vmpstr, 2015-05-11 20:27:29]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2015-05-11 20:28:10]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135833002/20001

[commit-bot: I haz the power, 2015-05-11 21:10:18]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-05-11 21:11:30]

Patchset 2 (id:??) landed as
https://crrev.com/e8624082aaf1743e46f2868f807ac164c587d77b
Cr-Commit-Position: refs/heads/master@{#329232}