Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Unified Diff: content/renderer/pepper/content_renderer_pepper_host_factory.cc

Issue 11358247: Revert 167727 - Add PPAPI permissions for file chooser, PDF, testing, video capture, and video deco… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/pepper/content_renderer_pepper_host_factory.cc
===================================================================
--- content/renderer/pepper/content_renderer_pepper_host_factory.cc (revision 167753)
+++ content/renderer/pepper/content_renderer_pepper_host_factory.cc (working copy)
@@ -37,15 +37,21 @@
if (!host_->IsValidInstance(instance))
return scoped_ptr<ResourceHost>();
- // Public interfaces.
+ // Stable interfaces.
switch (message.type()) {
case PpapiHostMsg_WebSocket_Create::ID:
return scoped_ptr<ResourceHost>(new PepperWebSocketHost(
host_, instance, params.pp_resource()));
}
- // Dev interfaces.
- if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV)) {
+ // Resources for dev interfaces.
+ // TODO(brettw) when we support any public or private interfaces, put them in
+ // a separate switch above.
+
+ // TODO(brettw) put back this dev check! This was removed to fix issue 138902
+ // where the permissions for bundled Flash (but not Flash that you specify
+ // on the command line, making it difficult to test) are incorrect.
+ /*if (GetPermissions().HasPermission(ppapi::PERMISSION_DEV))*/ {
switch (message.type()) {
case PpapiHostMsg_AudioInput_Create::ID:
return scoped_ptr<ResourceHost>(new PepperAudioInputHost(
@@ -56,7 +62,7 @@
}
}
- // Flash interfaces.
+ // Resources for Flash interfaces.
if (GetPermissions().HasPermission(ppapi::PERMISSION_FLASH)) {
switch (message.type()) {
case PpapiHostMsg_Flash_Create::ID:
« no previous file with comments | « content/browser/renderer_host/pepper/content_browser_pepper_host_factory.cc ('k') | ppapi/proxy/ppb_pdf_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698