src/runtime.cc - Issue 11358234: Object.observe: Handle oldValue for elements with accessors properly.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/runtime.cc

Issue 11358234: Object.observe: Handle oldValue for elements with accessors properly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Addressed comments. Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/runtime.cc

diff --git a/src/runtime.cc b/src/runtime.cc

index de74f2ca6240d69f13fbd45df4d232a833ba3759..a63b66d49254e4787b5ee8d00afab78bb219a36a 100644

--- a/src/runtime.cc

+++ b/src/runtime.cc

@@ -1091,7 +1091,7 @@ static MaybeObject* GetOwnProperty(Isolate* isolate,

// This could be an element.

uint32_t index;

if (name->AsArrayIndex(&index)) {

- switch (obj->GetLocalElementType(index)) {

+ switch (obj->GetLocalElementKind(index)) {

case JSObject::UNDEFINED_ELEMENT:

return heap->undefined_value();

@@ -4727,7 +4727,7 @@ RUNTIME_FUNCTION(MaybeObject*, Runtime_IsPropertyEnumerable) {

uint32_t index;

if (key->AsArrayIndex(&index)) {

- JSObject::LocalElementType type = object->GetLocalElementType(index);

+ JSObject::LocalElementKind type = object->GetLocalElementKind(index);

switch (type) {

case JSObject::UNDEFINED_ELEMENT:

case JSObject::STRING_CHARACTER_ELEMENT:

« no previous file with comments | « src/objects.cc ('k') | test/mjsunit/harmony/object-observe.js » ('j') | no next file with comments »