Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(881)

Unified Diff: src/objects.h

Issue 11358234: Object.observe: Handle oldValue for elements with accessors properly. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Addressed comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/elements.cc ('k') | src/objects.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.h
diff --git a/src/objects.h b/src/objects.h
index 3dc6188997bdead58671bc9982202033e64f5e38..28729d013198e7b54e6763a5340a23d0d75e4554 100644
--- a/src/objects.h
+++ b/src/objects.h
@@ -1835,8 +1835,13 @@ class JSObject: public JSReceiver {
return old_capacity + (old_capacity >> 1) + 16;
}
+ PropertyType GetLocalPropertyType(String* name);
+ PropertyType GetLocalElementType(uint32_t index);
+ AccessorPair* GetLocalPropertyAccessorPair(String* name);
+ AccessorPair* GetLocalElementAccessorPair(uint32_t index);
+
// Tells whether the index'th element is present and how it is stored.
- enum LocalElementType {
+ enum LocalElementKind {
// There is no element with given index.
UNDEFINED_ELEMENT,
@@ -1853,7 +1858,7 @@ class JSObject: public JSReceiver {
DICTIONARY_ELEMENT
};
- LocalElementType GetLocalElementType(uint32_t index);
+ LocalElementKind GetLocalElementKind(uint32_t index);
MUST_USE_RESULT MaybeObject* SetFastElement(uint32_t index,
Object* value,
« no previous file with comments | « src/elements.cc ('k') | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698