Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 1135823007: Prevent ProcessProxy from passing bad fds to ProcessOutputWatcher (Closed)

Created:
5 years, 7 months ago by tbarzic
Modified:
5 years, 7 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prevent ProcessProxy from passing bad fds to ProcessOutputWatcher This makes crosh process creation (used by terminalPrivate API) fail gracefully when file descriptors used to observe process output cannot be used by select (as opposed to crashing). BUG=480616 TEST=Open huge number of crosh terminals in short time, until terminal launching starts failing. Committed: https://crrev.com/296875c4f5717f003005ccfd1e2ed0fd5675bb4b Cr-Commit-Position: refs/heads/master@{#329901}

Patch Set 1 #

Patch Set 2 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -12 lines) Patch
M chromeos/process_proxy/process_output_watcher.h View 2 chunks +3 lines, -3 lines 0 comments Download
M chromeos/process_proxy/process_output_watcher.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M chromeos/process_proxy/process_proxy.cc View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tbarzic
Can you take a quick look at this?
5 years, 7 months ago (2015-05-14 19:01:25 UTC) #2
xiyuan
lgtm
5 years, 7 months ago (2015-05-14 19:10:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135823007/20001
5 years, 7 months ago (2015-05-14 19:21:50 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-14 19:40:46 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 19:42:17 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/296875c4f5717f003005ccfd1e2ed0fd5675bb4b
Cr-Commit-Position: refs/heads/master@{#329901}

Powered by Google App Engine
This is Rietveld 408576698