Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 11358211: Handle errors on the initialization of SyncFileSystemService (Closed)

Created:
8 years, 1 month ago by tzik
Modified:
8 years, 1 month ago
Reviewers:
kinuko
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch
Visibility:
Public.

Description

Handle errors on the initialization of SyncFileSystemService BUG=156041 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=167310

Patch Set 1 #

Patch Set 2 : +mock #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -4 lines) Patch
M chrome/browser/sync_file_system/mock_remote_file_sync_service.h View 1 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/mock_remote_file_sync_service.cc View 1 2 chunks +22 lines, -0 lines 0 comments Download
M chrome/browser/sync_file_system/sync_file_system_service.cc View 3 chunks +15 lines, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
tzik
PTAL
8 years, 1 month ago (2012-11-13 03:56:23 UTC) #1
kinuko
Yup, lgtm.
8 years, 1 month ago (2012-11-13 04:02:00 UTC) #2
kinuko
...not yet. I think we need to add mock default implementation not to hung the ...
8 years, 1 month ago (2012-11-13 04:14:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tzik@chromium.org/11358211/1
8 years, 1 month ago (2012-11-13 04:15:08 UTC) #4
tzik
On 2012/11/13 04:14:56, kinuko wrote: > ...not yet. I think we need to add mock ...
8 years, 1 month ago (2012-11-13 04:34:05 UTC) #5
kinuko
lgtm
8 years, 1 month ago (2012-11-13 04:46:49 UTC) #6
tzik
On 2012/11/13 04:46:49, kinuko wrote: > lgtm Thanks!
8 years, 1 month ago (2012-11-13 04:49:32 UTC) #7
commit-bot: I haz the power
8 years, 1 month ago (2012-11-13 04:49:54 UTC) #8

Powered by Google App Engine
This is Rietveld 408576698