Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: tools/testing/dart/test_suite.dart

Issue 11358175: Do not generate multiple tests for vm options. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/testing/dart/test_suite.dart
diff --git a/tools/testing/dart/test_suite.dart b/tools/testing/dart/test_suite.dart
index 50c7d30ac980a4dd98456e945b96d92b5840206b..fe37d722c38f5aa5c42de8e02b527435b131e1c5 100644
--- a/tools/testing/dart/test_suite.dart
+++ b/tools/testing/dart/test_suite.dart
@@ -1142,7 +1142,12 @@ class StandardTestSuite implements TestSuite {
Contains(configuration['runtime'],
const ['none', 'vm', 'drt', 'dartium']);
if (!needsVmOptions) return [[]];
- return optionsFromFile['vmOptions'];
+ final vmOptions = optionsFromFile['vmOptions'];
+ if (configuration['compiler'] != 'dart2dart') return vmOptions;
+ // Temporary workaround for race in test suite: tests with different
+ // vm options are still compiled into the same output file which
+ // may lead to reads from empty files.
+ return [vmOptions[0]];
}
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698