sdk/lib/_internal/compiler/implementation/compile_time_constants.dart - Issue 11358141: Do not always error-out when evaluating a map that is not a compile time constant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

Issue 11358141: Do not always error-out when evaluating a map that is not a compile time constant. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/compile_time_constants.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (revision 14621)

+++ sdk/lib/_internal/compiler/implementation/compile_time_constants.dart (working copy)

@@ -301,8 +301,7 @@

Constant visitLiteralMap(LiteralMap node) {

if (!node.isConst()) {

- signalNotCompileTimeConstant(node);

- error(node);

+ return signalNotCompileTimeConstant(node);

}

List<StringConstant> keys = <StringConstant>[];

Map<StringConstant, Constant> map = new Map<StringConstant, Constant>();

« no previous file with comments | « no previous file | tests/language/lazy_map_test.dart » ('j') | no next file with comments »