Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(544)

Issue 1135813006: Add background fetch capability to ios tests (Closed)

Created:
5 years, 7 months ago by Olivier
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add background fetch capability to ios tests Application has this capability, kif tests should mirror it. BUG=421798 Committed: https://crrev.com/25aaa43552d4ceac737bee614e2e181de8946f79 Cr-Commit-Position: refs/heads/master@{#329621}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M testing/gtest_ios/unittest-Info.plist View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Olivier
5 years, 7 months ago (2015-05-11 16:21:49 UTC) #2
pkl (ping after 24h if needed)
LGTM, but please fix description s/miror/mirror/
5 years, 7 months ago (2015-05-12 21:50:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135813006/1
5 years, 7 months ago (2015-05-13 08:18:08 UTC) #5
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 7 months ago (2015-05-13 08:18:10 UTC) #7
Olivier
5 years, 7 months ago (2015-05-13 08:21:36 UTC) #9
sdefresne
lgtm
5 years, 7 months ago (2015-05-13 12:48:39 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135813006/1
5 years, 7 months ago (2015-05-13 12:48:48 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-13 12:56:29 UTC) #13
commit-bot: I haz the power
5 years, 7 months ago (2015-05-13 12:58:13 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/25aaa43552d4ceac737bee614e2e181de8946f79
Cr-Commit-Position: refs/heads/master@{#329621}

Powered by Google App Engine
This is Rietveld 408576698