Issue 11358128: git-1.8.0 requires TERM to be set appropriately for commands that

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358128: git-1.8.0 requires TERM to be set appropriately for commands that (Closed)

Created:
8 years, 1 month ago by szager1

Modified:
8 years, 1 month ago

Reviewers:
cmp, M-A Ruel

CC:
chromium-reviews, Dirk Pranke, cmp+cc_chromium.org, M-A Ruel

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

More Reviews

Description

git-1.8.0 requires TERM to be set appropriately for commands that page output. Rather than recreate the entire msysgit zip file and for everyone to download it again, just modify git.bat in place. TBR=maruel@chromium.org,cmp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=166295

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -4 lines)			Patch
	M	bootstrap/win/win_tools.bat	View		3 chunks	+15 lines, -4 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

8 years, 1 month ago (2012-11-07 01:34:07 UTC) #3

https://codereview.chromium.org/11358128/diff/2001/bootstrap/win/win_tools.bat
File bootstrap/win/win_tools.bat (right):

https://codereview.chromium.org/11358128/diff/2001/bootstrap/win/win_tools.ba...
bootstrap/win/win_tools.bat:71: call FIND "TERM" "%WIN_TOOLS_ROOT_DIR%\git.bat"
2>nul 1>nul
personally I'd keep find, findstr and move lowercase to stay consistent with the
rest of this file.

It's worth the cost of calling this script everytime to save on updating a few
hundreds of users once?

Expand Messages | Collapse Messages