Issue 11358122: Object.observe: Fixed missing case for turning off ICs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11358122: Object.observe: Fixed missing case for turning off ICs. (Closed)

Created:
8 years, 1 month ago by rossberg

Modified:
8 years, 1 month ago

Reviewers:
rafaelw, Michael Starzinger

CC:
v8-dev, adamk, rafaelw

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Object.observe: Fixed missing case for turning off ICs. R=mstarzinger@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=12901

Patch Set 1 #

Total comments: 3

Created: 8 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+35 lines, -1 line)			Patch
	M	src/ic.cc	View		1 chunk	+3 lines, -1 line	3 comments	Download
	M	test/mjsunit/harmony/object-observe.js	View		1 chunk	+32 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rafaelw

https://codereview.chromium.org/11358122/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/11358122/diff/1/src/ic.cc#newcode1922 src/ic.cc:1922: // Do not use ICs for objects that require ...

8 years, 1 month ago (2012-11-07 09:10:10 UTC) #2

Michael Starzinger

LGTM. https://codereview.chromium.org/11358122/diff/1/src/ic.cc File src/ic.cc (right): https://codereview.chromium.org/11358122/diff/1/src/ic.cc#newcode1922 src/ic.cc:1922: // Do not use ICs for objects that ...

8 years, 1 month ago (2012-11-07 11:08:29 UTC) #3

rossberg

8 years, 1 month ago (2012-11-07 12:23:49 UTC) #4

https://chromiumcodereview.appspot.com/11358122/diff/1/src/ic.cc
File src/ic.cc (right):

https://chromiumcodereview.appspot.com/11358122/diff/1/src/ic.cc#newcode1922
src/ic.cc:1922: // Do not use ICs for objects that require access checks
(including
On 2012/11/07 09:10:10, rafaelw wrote:
> Maybe update comment?

Done.

Expand Messages | Collapse Messages