Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Unified Diff: lib/html/src/dart2js_Conversions.dart

Issue 11358060: Change NotImplementedException to UnimplementedError. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Address review comments. Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/src/native_DOMImplementation.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/src/dart2js_Conversions.dart
diff --git a/lib/html/src/dart2js_Conversions.dart b/lib/html/src/dart2js_Conversions.dart
index 5ce880697f8c52c2fc2d5615e10af7b9ac195fec..5e69b7c9d6bad43de87c51e7fbc72518f49ab7bf 100644
--- a/lib/html/src/dart2js_Conversions.dart
+++ b/lib/html/src/dart2js_Conversions.dart
@@ -136,7 +136,7 @@ _convertNativeToDart_IDBKey(nativeKey) {
return false; // number, string.
}
if (containsDate(nativeKey)) {
- throw const NotImplementedException('IDBKey containing Date');
+ throw new UnimplementedError('IDBKey containing Date');
}
// TODO: Cache conversion somewhere?
return nativeKey;
@@ -217,11 +217,11 @@ _convertDartToNative_PrepareForStructuredClone(value) {
if (e is String) return e;
if (e is Date) {
// TODO(sra).
- throw const NotImplementedException('structured clone of Date');
+ throw new UnimplementedError('structured clone of Date');
}
if (e is RegExp) {
// TODO(sra).
- throw const NotImplementedException('structured clone of RegExp');
+ throw new UnimplementedError('structured clone of RegExp');
}
// The browser's internal structured cloning algorithm will copy certain
@@ -233,12 +233,12 @@ _convertDartToNative_PrepareForStructuredClone(value) {
if (e is _FileImpl) return e;
if (e is File) {
- throw const NotImplementedException('structured clone of File');
+ throw new UnimplementedError('structured clone of File');
}
if (e is _BlobImpl) return e;
if (e is Blob) {
- throw const NotImplementedException('structured clone of Blob');
+ throw new UnimplementedError('structured clone of Blob');
}
if (e is _FileListImpl) return e;
@@ -246,17 +246,17 @@ _convertDartToNative_PrepareForStructuredClone(value) {
// TODO(sra): Firefox: How to convert _TypedImageData on the other end?
if (e is _ImageDataImpl) return e;
if (e is ImageData) {
- throw const NotImplementedException('structured clone of ImageData');
+ throw new UnimplementedError('structured clone of ImageData');
}
if (e is _ArrayBufferImpl) return e;
if (e is ArrayBuffer) {
- throw const NotImplementedException('structured clone of ArrayBuffer');
+ throw new UnimplementedError('structured clone of ArrayBuffer');
}
if (e is _ArrayBufferViewImpl) return e;
if (e is ArrayBufferView) {
- throw const NotImplementedException('structured clone of ArrayBufferView');
+ throw new UnimplementedError('structured clone of ArrayBufferView');
}
if (e is Map) {
@@ -328,7 +328,7 @@ _convertDartToNative_PrepareForStructuredClone(value) {
return copy;
}
- throw const NotImplementedException('structured clone of other type');
+ throw new UnimplementedError('structured clone of other type');
}
var copy = walk(value);
@@ -381,12 +381,12 @@ _convertNativeToDart_AcceptStructuredClone(object, {mustCopy = false}) {
if (_isJavaScriptDate(e)) {
// TODO(sra).
- throw const NotImplementedException('structured clone of Date');
+ throw new UnimplementedError('structured clone of Date');
}
if (_isJavaScriptRegExp(e)) {
// TODO(sra).
- throw const NotImplementedException('structured clone of RegExp');
+ throw new UnimplementedError('structured clone of RegExp');
}
if (_isJavaScriptSimpleObject(e)) {
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | lib/html/src/native_DOMImplementation.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698