Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1248)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 11358060: Change NotImplementedException to UnimplementedError. (Closed)

Created:
8 years, 1 month ago by Lasse Reichstein Nielsen
Modified:
8 years, 1 month ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Change NotImplementedException to UnimplementedError. Retain a NotImplementedException type for backwards compatibility. This class will be removed soon. The constructor of UnimplementedError is currently const in order to support the NotImplementedException. That will be fixed too. Committed: https://code.google.com/p/dart/source/detail?r=14467

Patch Set 1 #

Total comments: 4

Patch Set 2 : address review comments. #

Total comments: 4

Patch Set 3 : Address review comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -101 lines) Patch
M lib/compiler/implementation/lib/isolate_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/core/errors.dart View 1 2 1 chunk +29 lines, -0 lines 0 comments Download
M lib/core/exceptions.dart View 1 chunk +0 lines, -9 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 9 chunks +16 lines, -16 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M lib/html/src/dart2js_Conversions.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M lib/html/src/native_DOMImplementation.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/html/templates/html/impl/impl_DocumentFragment.darttemplate View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/html/templates/html/impl/impl_Element.darttemplate View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/io/path_impl.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/intl/lib/src/date_format_field.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/unittest/lib/src/core_matchers.dart View 1 chunk +15 lines, -6 lines 0 comments Download
M pkg/unittest/test/matchers_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M runtime/lib/function_patch.dart View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/mirrors_impl.dart View 16 chunks +21 lines, -21 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_remote_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/ui_lib/observable/observable.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M samples/ui_lib/touch/TouchUtil.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/html/cssstyledeclaration_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/html/documentfragment_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/language/named_parameters_with_dollars_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/utils/vim/syntax/dart.vim View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Lasse Reichstein Nielsen
8 years, 1 month ago (2012-11-02 11:53:04 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/11358060/diff/1/lib/core/errors.dart File lib/core/errors.dart (right): https://codereview.chromium.org/11358060/diff/1/lib/core/errors.dart#newcode214 lib/core/errors.dart:214: * This operation has not been implemented yet. ...
8 years, 1 month ago (2012-11-02 12:02:32 UTC) #2
Lasse Reichstein Nielsen
https://codereview.chromium.org/11358060/diff/1/lib/core/errors.dart File lib/core/errors.dart (right): https://codereview.chromium.org/11358060/diff/1/lib/core/errors.dart#newcode214 lib/core/errors.dart:214: * This operation has not been implemented yet. Reworded. ...
8 years, 1 month ago (2012-11-02 12:15:40 UTC) #3
floitsch
https://codereview.chromium.org/11358060/diff/5001/lib/core/errors.dart File lib/core/errors.dart (right): https://codereview.chromium.org/11358060/diff/5001/lib/core/errors.dart#newcode214 lib/core/errors.dart:214: * Thrown by operations that have not yet been ...
8 years, 1 month ago (2012-11-02 12:25:12 UTC) #4
Lasse Reichstein Nielsen
8 years, 1 month ago (2012-11-02 12:35:38 UTC) #5 
https://codereview.chromium.org/11358060/diff/5001/lib/core/errors.dart
File lib/core/errors.dart (right):

https://codereview.chromium.org/11358060/diff/5001/lib/core/errors.dart#newco...
lib/core/errors.dart:214: * Thrown by operations that have not yet been
implemented.
On 2012/11/02 12:25:12, floitsch wrote:
> have not been implemented yet ?

Done.

https://codereview.chromium.org/11358060/diff/5001/lib/core/errors.dart#newco...
lib/core/errors.dart:217: * all the features it needs.
On 2012/11/02 12:25:12, floitsch wrote:
> If you intend to have a line-break in the output, add another NL.

Done.

Powered by Google App Engine
This is Rietveld 408576698