Add is_intrinsic and is_not_intrinsic bits to prevent repeated tests on the same function (inlining…

runtime/vm/intrinsifier.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 // Class for intrinsifying functions.
 
 #include "vm/intrinsifier.h"
 #include "vm/flags.h"
 #include "vm/object.h"
 
 namespace dart {
@@ skipping 51 matching lines @@
       return false;
     }
   }
   return CompareNames(test_class_name, function_class_name) &&
          CompareNames(test_function_name, function_name);
 }
 
 
 bool Intrinsifier::CanIntrinsify(const Function& function) {
   if (!FLAG_intrinsify) return false;
+  // Intrinsic kind is set lazily below.
+  if (function.intrinsic_kind() == Function::kIsIntrinsic) return true;
+  if (function.intrinsic_kind() == Function::kIsNotIntrinsic) return false;
   // Closure functions may have different arguments.
   if (function.IsClosureFunction()) return false;

[siva, 2012/11/01 23:04:06]

Should we do the closure function check first because
to always return false for these and the intrinsic bits will
never be set.

[srdjan, 2012/11/01 23:08:18]

Done.

   const char* function_name = String::Handle(function.name()).ToCString();
   const Class& function_class = Class::Handle(function.Owner());
   const char* class_name = String::Handle(function_class.Name()).ToCString();
   // Only core, math and scalarlist library methods can be intrinsified.
   const Library& core_lib = Library::Handle(Library::CoreLibrary());
   const Library& core_impl_lib = Library::Handle(Library::CoreImplLibrary());
   const Library& math_lib = Library::Handle(Library::MathLibrary());
   const Library& scalarlist_lib = Library::Handle(Library::ScalarlistLibrary());
   if ((function_class.library() != core_lib.raw()) &&
       (function_class.library() != core_impl_lib.raw()) &&
       (function_class.library() != math_lib.raw()) &&
       (function_class.library() != scalarlist_lib.raw())) {
     return false;
   }

[siva, 2012/11/01 23:04:06]

Not related to your current change I was wondering if
we could move the line
const char*class_name = String::Handle(function_class.Name()).ToCString() to
after the if check it would save a handle creation for the negative case.

Also I don't think you need the core_lib, core_impl_lib handles, we could write
if (function_class.library() != Library::CoreLibrary() &&
    function_class.library() != Library::CoreImplLibrary()
    ....) {
  return false;
}

[srdjan, 2012/11/01 23:08:18]

Done.

 #define FIND_INTRINSICS(test_class_name, test_function_name, destination)      \
   if (TestFunction(function,                                                   \
                    class_name, function_name,                                  \
                    #test_class_name, #test_function_name)) {                   \
+    function.set_intrinsic_kind(Function::kIsIntrinsic);                       \
     return true;                                                               \
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
+  function.set_intrinsic_kind(Function::kIsNotIntrinsic);
   return false;
 }
 
 bool Intrinsifier::Intrinsify(const Function& function, Assembler* assembler) {
   if (!CanIntrinsify(function)) return false;
   const char* function_name = String::Handle(function.name()).ToCString();
   const Class& function_class = Class::Handle(function.Owner());
   const char* class_name = String::Handle(function_class.Name()).ToCString();
 #define FIND_INTRINSICS(test_class_name, test_function_name, destination)      \
   if (TestFunction(function,                                                   \
                    class_name, function_name,                                  \
                    #test_class_name, #test_function_name)) {                   \
     return destination(assembler);                                             \
   }                                                                            \
 
 INTRINSIC_LIST(FIND_INTRINSICS);
 #undef FIND_INTRINSICS
   return false;
 }
 
 }  // namespace dart