Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issue 11358017: Update DEPS to latest llvm.git commit (Closed)

Created:
8 years, 1 month ago by eliben
Modified:
8 years, 1 month ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Update DEPS to latest llvm.git commit BUG= Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=10148

Patch Set 1 #

Total comments: 1

Patch Set 2 : fixing the hash #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pnacl/DEPS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
eliben
8 years, 1 month ago (2012-10-31 18:37:38 UTC) #1
jvoung - send to chromium...
https://codereview.chromium.org/11358017/diff/1/pnacl/DEPS File pnacl/DEPS (right): https://codereview.chromium.org/11358017/diff/1/pnacl/DEPS#newcode2 pnacl/DEPS:2: "pnacl_llvm_rev": "f86cd27e0bf11b7ce13faa2a7251442c4457ed69", is that really the right hash? I ...
8 years, 1 month ago (2012-10-31 18:42:00 UTC) #2
eliben
On 2012/10/31 18:42:00, jvoung wrote: > https://codereview.chromium.org/11358017/diff/1/pnacl/DEPS > File pnacl/DEPS (right): > > https://codereview.chromium.org/11358017/diff/1/pnacl/DEPS#newcode2 > ...
8 years, 1 month ago (2012-10-31 18:44:24 UTC) #3
jvoung - send to chromium...
LGTM
8 years, 1 month ago (2012-10-31 18:58:09 UTC) #4
jvoung - send to chromium...
8 years, 1 month ago (2012-10-31 22:45:18 UTC) #5
On 2012/10/31 18:58:09, jvoung wrote:
> LGTM

Hi Eli,

There were some tests that use the assembler, which maybe didn't run with
"test-all", but which happen to be run on this bot:

http://build.chromium.org/p/client.nacl.toolchain/builders/linux-pnacl-x86_64...

on the "toolchain waterfall".  You should see the commandline at the top of the
log for how to reproduce this.  Grep for our friend "NACLENTRYALIGN" =)


Perhaps the test wasn't in the "non_portable_tests" test-suite and got skipped
in test-all.

Powered by Google App Engine
This is Rietveld 408576698