Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issue 11358013: Merge 132848 - IndexedDB: Crash on checking version of corrupt backing store (Closed)

Created:
8 years, 1 month ago by jsbell
Modified:
8 years, 1 month ago
Reviewers:
jsbell
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1312/
Visibility:
Public.

Description

Merge 132848 - IndexedDB: Crash on checking version of corrupt backing store https://bugs.webkit.org/show_bug.cgi?id=100692 Reviewed by Tony Chang. If the backing store fails to open (due to corruption, non-writeable disk, etc) the subsequent schema version check dereferences a null pointer. Fix to only do the schema check if the database opened. Chromium tests will be included with crrev.com/11196029 * Modules/indexeddb/IDBLevelDBBackingStore.cpp: (WebCore::IDBLevelDBBackingStore::open): TBR=jsbell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=133043

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/WebCore/Modules/indexeddb/IDBLevelDBBackingStore.cpp View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
jsbell
8 years, 1 month ago (2012-10-31 17:19:11 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698