Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1135793006: [net/base] Forward declaration of classes instead of including header (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
mmenke
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Forward declaration of class instead of including header in net/base as per chromium's guidelines https://www.chromium.org/developers/coding-style/cpp-dos-and-donts#TOC-Forward-declare-classes-instead-of-including-headers. Committed: https://crrev.com/3cd0301c2d6a3a59c22db36be6df9ec004d6d6a4 Cr-Commit-Position: refs/heads/master@{#330708}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed Review Comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M net/base/directory_lister.h View 1 chunk +4 lines, -1 line 0 comments Download
M net/base/directory_lister.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M net/base/directory_lister_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 10 (4 generated)
Pranay
Hi PTAL Thanks
5 years, 7 months ago (2015-05-19 13:15:34 UTC) #2
mmenke
LGTM! https://codereview.chromium.org/1135793006/diff/1/net/base/directory_lister.cc File net/base/directory_lister.cc (right): https://codereview.chromium.org/1135793006/diff/1/net/base/directory_lister.cc#newcode14 net/base/directory_lister.cc:14: #include "base/message_loop/message_loop.h" While you're here, I believe you ...
5 years, 7 months ago (2015-05-19 14:45:16 UTC) #3
Pranay
https://codereview.chromium.org/1135793006/diff/1/net/base/directory_lister.cc File net/base/directory_lister.cc (right): https://codereview.chromium.org/1135793006/diff/1/net/base/directory_lister.cc#newcode14 net/base/directory_lister.cc:14: #include "base/message_loop/message_loop.h" This file has FROM_HERE flag ( dependency ...
5 years, 7 months ago (2015-05-20 03:09:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135793006/20001
5 years, 7 months ago (2015-05-20 05:31:50 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 7 months ago (2015-05-20 07:12:02 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-20 07:13:22 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3cd0301c2d6a3a59c22db36be6df9ec004d6d6a4
Cr-Commit-Position: refs/heads/master@{#330708}

Powered by Google App Engine
This is Rietveld 408576698