Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Issue 1135793002: Using ThreadTaskRunnerHandle in lieu of MessageLoopProxy in google_apis module (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews, zea+watch_chromium.org, Pranay
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Using ThreadTaskRunnerHandle in lieu of MessageLoopProxy in google_apis module MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/a898c5cf420b99d1014c639ca2271630b3369744 Cr-Commit-Position: refs/heads/master@{#329192}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -9 lines) Patch
M google_apis/drive/task_util.h View 2 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gaia/oauth2_access_token_fetcher_impl_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gaia/oauth2_token_service_request_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gaia/ubertoken_fetcher_unittest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M google_apis/gcm/engine/gcm_store_impl.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M google_apis/gcm/tools/mcs_probe.cc View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-08 15:37:42 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm
5 years, 7 months ago (2015-05-11 16:58:49 UTC) #3
anujsharma
On 2015/05/11 16:58:49, Roger Tawa wrote: > lgtm Thanks Roger Tawa for lgtm.
5 years, 7 months ago (2015-05-11 17:18:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135793002/1
5 years, 7 months ago (2015-05-11 17:25:41 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-11 18:18:41 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-11 18:19:39 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a898c5cf420b99d1014c639ca2271630b3369744
Cr-Commit-Position: refs/heads/master@{#329192}

Powered by Google App Engine
This is Rietveld 408576698