Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issue 1135773002: When location is turned off in system, make sure we don't show the Allowed/Blocked list. (Closed)

Created:
5 years, 7 months ago by Finnur
Modified:
5 years, 7 months ago
Reviewers:
newt (away)
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

When location is turned off in system, make sure we don't show the Allowed/Blocked list. The only thing visible in the content area should be the "Turn on location in Android Settings" link. BUG=486008 Committed: https://crrev.com/85c035ae19a04cba098b24f2bc4ec04f931700b8 Cr-Commit-Position: refs/heads/master@{#329382}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/WebsitePreferences.java View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Finnur
5 years, 7 months ago (2015-05-08 14:13:45 UTC) #2
newt (away)
lgtm
5 years, 7 months ago (2015-05-11 15:57:42 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135773002/1
5 years, 7 months ago (2015-05-12 09:08:09 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-12 09:34:43 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-12 09:35:24 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/85c035ae19a04cba098b24f2bc4ec04f931700b8
Cr-Commit-Position: refs/heads/master@{#329382}

Powered by Google App Engine
This is Rietveld 408576698