[Extensions Toolbar] Only include relevant items in component extensions' menus

[Extensions Toolbar] Only include relevant items in component extensions' menus

Only include items that are relevant to component extensions in their context
menus. That is to say, don't show the "Remove", "Manage extensions", or "Inspect
popup" items, and only show the "Options" item if there is an options page.

BUG=486223
Committed: https://crrev.com/0515a3bb0ddfa833c1ece005182d2e74b8aee748
Cr-Commit-Position: refs/heads/master@{#329928}

[Devlin, 2015-05-08 22:55:06]

Patchset #1 (id:1) has been deleted

[Devlin, 2015-05-08 23:16:15]

rdevlin.cronin@chromium.org changed reviewers:
+ finnur@chromium.org

[Devlin, 2015-05-08 23:16:15]

And this one. :)

[Finnur, 2015-05-13 15:54:01]

LGTM, one nit/question.

https://codereview.chromium.org/1135763004/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1135763004/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:306: if
(!is_component_ || extensions::OptionsPageInfo::HasOptionsPage(extension))
nit: Interesting. Why show it for non-component extensions that don't have an
options page?

[Devlin, 2015-05-14 19:15:22]

https://codereview.chromium.org/1135763004/diff/20001/chrome/browser/extensio...
File chrome/browser/extensions/extension_context_menu_model.cc (right):

https://codereview.chromium.org/1135763004/diff/20001/chrome/browser/extensio...
chrome/browser/extensions/extension_context_menu_model.cc:306: if
(!is_component_ || extensions::OptionsPageInfo::HasOptionsPage(extension))
On 2015/05/13 15:54:01, Finnur (OOO Thu -- holiday) wrote:
> nit: Interesting. Why show it for non-component extensions that don't have an
> options page?

I suspect this came from a UI decision to have the context menus for extensions
look very similar to one another (perhaps to reinforce that something *is* an
extension?  We can ignore it for component extensions, since there more a part
of chrome), and have all the same items present.  I don't know if it's still a
valid concern.

Out of interest of keeping the impact here small, leaving it as current behavior
for now - but probably worth revisiting in the future.

[Devlin, 2015-05-14 19:15:26]

The CQ bit was checked by rdevlin.cronin@chromium.org

[Devlin, 2015-05-14 19:15:26]

The patchset sent to the CQ was uploaded after l-g-t-m from finnur@chromium.org
Link to the patchset: https://codereview.chromium.org/1135763004/#ps40001
(title: "Latest master")

[commit-bot: I haz the power, 2015-05-14 19:16:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1135763004/40001

[commit-bot: I haz the power, 2015-05-14 20:51:02]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-05-14 20:52:13]

Patchset 2 (id:??) landed as
https://crrev.com/0515a3bb0ddfa833c1ece005182d2e74b8aee748
Cr-Commit-Position: refs/heads/master@{#329928}