Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Issue 1135753004: Fix GrAARectRenderer's handling of unsorted nested rects (Closed)

Created:
5 years, 7 months ago by robertphillips
Modified:
5 years, 7 months ago
Reviewers:
bsalomon, caryclark
CC:
reviews_skia.org, caryclark
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix GrAARectRenderer's handling of unsorted nested rects What is going on here is that, after the mapPoints in fillAANestedRects, devInside was upside down so the isEmpty check was always firing. I don't see why we need to avoid having devInside sorted. BUG=488103 Committed: https://skia.googlesource.com/skia/+/2e5b4c52c59f838af0e0a2e5550dcffa4d3756cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -12 lines) Patch
M gm/nested.cpp View 5 chunks +24 lines, -9 lines 0 comments Download
M src/gpu/GrAARectRenderer.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (6 generated)
robertphillips
5 years, 7 months ago (2015-05-18 15:23:46 UTC) #2
robertphillips
5 years, 7 months ago (2015-05-18 15:24:08 UTC) #4
caryclark
lgtm
5 years, 7 months ago (2015-05-18 15:52:40 UTC) #6
bsalomon
On 2015/05/18 15:52:40, caryclark wrote: > lgtm lgtm, too. But let's make sure we handle ...
5 years, 7 months ago (2015-05-18 16:24:11 UTC) #7
robertphillips
GrContext.cpp::is_nested_rects explicitly checks that the directions returned from isNestedFillRects are opposite.
5 years, 7 months ago (2015-05-18 18:27:03 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135753004/1
5 years, 7 months ago (2015-05-18 18:28:10 UTC) #10
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-18 20:01:54 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135753004/1
5 years, 7 months ago (2015-05-19 11:35:17 UTC) #14
commit-bot: I haz the power
5 years, 7 months ago (2015-05-19 11:35:44 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/2e5b4c52c59f838af0e0a2e5550dcffa4d3756cd

Powered by Google App Engine
This is Rietveld 408576698