Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 1135753002: Add support for new-ish V8 use counters (Closed)

Created:
5 years, 7 months ago by Erik Corry
Modified:
5 years, 7 months ago
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, vivekg_samsung, vivekg
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Add support for new-ish V8 use counters R=jochen@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=195119

Patch Set 1 #

Patch Set 2 : Fix merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
M Source/bindings/core/v8/V8PerIsolateData.cpp View 1 chunk +12 lines, -0 lines 0 comments Download
M Source/core/frame/UseCounter.h View 1 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Erik Corry
5 years, 7 months ago (2015-05-08 10:38:08 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 7 months ago (2015-05-08 10:40:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135753002/1
5 years, 7 months ago (2015-05-08 11:01:43 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: mac_blink_compile_dbg on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/builds/44179)
5 years, 7 months ago (2015-05-08 11:05:06 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135753002/20001
5 years, 7 months ago (2015-05-08 11:34:24 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://src.chromium.org/viewvc/blink?view=rev&revision=195119
5 years, 7 months ago (2015-05-08 15:54:08 UTC) #10
haraken
LGTM
5 years, 7 months ago (2015-05-08 23:24:07 UTC) #11
sof
5 years, 7 months ago (2015-05-09 14:01:10 UTC) #12
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/1131413002/ by sigbjornf@opera.com.

The reason for reverting is: The v8 use counters now being handled are reported
over an Isolate for which callingExecutionContext() fails --

 
https://storage.googleapis.com/chromium-layout-test-archives/WebKit_Mac_Oilpa...

(first build on Mac Oilpan(dbg) with the new crashes.).

Powered by Google App Engine
This is Rietveld 408576698