content/common/gpu/client/context_provider_command_buffer.cc - Issue 1135743004: cc: Add null checks for GrContext created by ContextProviderCommandBuffer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/common/gpu/client/context_provider_command_buffer.cc

Issue 1135743004: cc: Add null checks for GrContext created by ContextProviderCommandBuffer. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Worker context provider's lock must be held during GrContext creation. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/common/gpu/client/context_provider_command_buffer.cc

diff --git a/content/common/gpu/client/context_provider_command_buffer.cc b/content/common/gpu/client/context_provider_command_buffer.cc

index 2f00de1fe296877762620733ff3c02dcad436d66..58e34b6431795a18818a84cafde51f9889987eba 100644

--- a/content/common/gpu/client/context_provider_command_buffer.cc

+++ b/content/common/gpu/client/context_provider_command_buffer.cc

@@ -137,7 +137,7 @@ class GrContext* ContextProviderCommandBuffer::GrContext() {

gr_context_.reset(new GrContextForWebGraphicsContext3D(context3d_.get()));

// If GlContext is already lost, also abandon the new GrContext.

- if (IsContextLost())

+ if (gr_context_->get() && IsContextLost())

gr_context_->get()->abandonContext();

return gr_context_->get();

« no previous file with comments | « cc/trees/layer_tree_host_impl_unittest.cc ('k') | no next file » | no next file with comments »