Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(912)

Unified Diff: content/browser/service_worker/service_worker_browsertest.cc

Issue 1135743002: Check the size of ResourceRecords in ServiceWorkerDatabase::ReadRegistration() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: DCHECK in ServiceWorkerStorage::ReturnFoundRegistration() Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_browsertest.cc
diff --git a/content/browser/service_worker/service_worker_browsertest.cc b/content/browser/service_worker/service_worker_browsertest.cc
index dc2bec68d36f9db67f6e0ca5d82bc51db1d4b46c..03b2041533e4b22ba6584eb6abf4df5b51bc5e53 100644
--- a/content/browser/service_worker/service_worker_browsertest.cc
+++ b/content/browser/service_worker/service_worker_browsertest.cc
@@ -846,11 +846,10 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, StartNotFound) {
}
IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, ReadResourceFailure) {
- // Create and store a registration.
+ // Create a registration.
RunOnIOThread(base::Bind(&self::SetUpRegistrationOnIOThread, this,
"/service_worker/worker.js"));
version_->SetStatus(ServiceWorkerVersion::ACTIVATED);
- StoreRegistration(version_->version_id(), SERVICE_WORKER_OK);
// Add a non-existent resource to the version.
std::vector<ServiceWorkerDatabase::ResourceRecord> records;
@@ -858,6 +857,9 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest, ReadResourceFailure) {
ServiceWorkerDatabase::ResourceRecord(30, version_->script_url(), 100));
version_->script_cache_map()->SetResources(records);
+ // Store the registration.
+ StoreRegistration(version_->version_id(), SERVICE_WORKER_OK);
+
// Start the worker. We'll fail to read the resource.
StartWorker(SERVICE_WORKER_ERROR_DISK_CACHE);
EXPECT_EQ(ServiceWorkerVersion::REDUNDANT, version_->status());
@@ -897,6 +899,7 @@ IN_PROC_BROWSER_TEST_F(ServiceWorkerVersionBrowserTest,
// Make a waiting version and store it.
RunOnIOThread(base::Bind(&self::AddWaitingWorkerOnIOThread, this,
"/service_worker/worker.js"));
+ registration_->waiting_version()->script_cache_map()->SetResources(records);
StoreRegistration(registration_->waiting_version()->version_id(),
SERVICE_WORKER_OK);

Powered by Google App Engine
This is Rietveld 408576698