Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Issue 1135733006: Pass shader version to varying link check (Closed)

Created:
5 years, 7 months ago by oetuaho-nv
Modified:
5 years, 7 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Pass shader version to varying link check Rules for invariant varying (or in/out variable) matching are different for ESSL 3 and ESSL 1. Use a recently added ANGLE API to choose which rules to use based on shader version. Tested by WebGL 2 test deqp/data/gles3/shaders/qualification_order.html BUG=488372 TEST=WebGL 2 conformance tests Committed: https://crrev.com/fe5270311b555b02e2779541a1577e2fa7ff66a5 Cr-Commit-Position: refs/heads/master@{#330335}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M gpu/command_buffer/service/program_manager.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
oetuaho-nv
Please review! Should we try to also update content/test/gpu/gpu_tests/webgl_conformance_expectations.py in the same patch? I'm not ...
5 years, 7 months ago (2015-05-15 11:25:32 UTC) #2
Zhenyao Mo
On 2015/05/15 11:25:32, oetuaho-nv wrote: > Please review! > > Should we try to also ...
5 years, 7 months ago (2015-05-15 17:19:39 UTC) #3
Zhenyao Mo
Assume ANGLE already rolled in with the extra version param?
5 years, 7 months ago (2015-05-15 17:20:21 UTC) #4
oetuaho-nv
On 2015/05/15 17:20:21, Zhenyao Mo wrote: > Assume ANGLE already rolled in with the extra ...
5 years, 7 months ago (2015-05-18 07:13:50 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135733006/1
5 years, 7 months ago (2015-05-18 07:14:42 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-18 08:18:30 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/fe5270311b555b02e2779541a1577e2fa7ff66a5 Cr-Commit-Position: refs/heads/master@{#330335}
5 years, 7 months ago (2015-05-18 11:33:58 UTC) #9
oetuaho-nv
I looked for the results of WebGL 2 conformance tests on the GPU bots but ...
5 years, 7 months ago (2015-05-18 12:18:57 UTC) #10
Ken Russell (switch to Gerrit)
5 years, 7 months ago (2015-05-18 19:00:16 UTC) #11
Message was sent while issue was closed.
On 2015/05/18 12:18:57, oetuaho-nv wrote:
> I looked for the results of WebGL 2 conformance tests on the GPU bots but
> couldn't find them. I was looking at the "webgl_conformance_tests" stdio log.
> Are they somewhere else in there?

The WebGL 2 conformance tests aren't yet running as part of the testing on the
GPU bots. zmo's been starting to put this in place.

Powered by Google App Engine
This is Rietveld 408576698