Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1135713006: Revert of [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue (Closed)

Created:
5 years, 7 months ago by jbudorick
Modified:
5 years, 7 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue (patchset #1 id:1 of https://codereview.chromium.org/1134543002/) Reason for revert: This test is flaky: main waterfall: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg%29/builds/27776 blink waterfall: http://build.chromium.org/p/chromium.webkit/builders/Android%20Tests%20%28dbg%29/builds/25898 cq: http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_android_rel_ng/builds/20902 Original issue's description: > [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue > > The test reproduces the condition which was triggering an infinite loop > inside GinJavaBridgeDispatcherHost::RenderFrameDeleted. > > Verified that the test indeed hangs up and timeouts if the fix is removed. > > BUG=484927 > > Committed: https://crrev.com/326214e563fba72a044205e784c8f4f7bfef2f85 > Cr-Commit-Position: refs/heads/master@{#328900} TBR=sgurun@chromium.org,tedchoc@chromium.org,mnaganov@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=484927 Committed: https://crrev.com/44045a9317cb886a53eca5a527c7576226206b6b Cr-Commit-Position: refs/heads/master@{#329020}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -55 lines) Patch
M content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeChildFrameTest.java View 2 chunks +0 lines, -55 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Android] Add a regression test for the JB RemoveHolderAndAdvanceLocked issue
5 years, 7 months ago (2015-05-08 21:32:37 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135713006/1
5 years, 7 months ago (2015-05-08 21:37:56 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-08 21:43:01 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-08 21:44:36 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/44045a9317cb886a53eca5a527c7576226206b6b
Cr-Commit-Position: refs/heads/master@{#329020}

Powered by Google App Engine
This is Rietveld 408576698