Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 1135703004: core_services: add native_viewport_service on non-android. (Closed)

Created:
5 years, 7 months ago by Elliot Glaysher
Modified:
5 years, 7 months ago
CC:
chromium-reviews, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

core_services: add native_viewport_service on non-android. This moves native_viewport_service into core_services on desktop mandoline builds, colocating the service with the surfaces service. We can't do this on android yet because android does some tricks with the ApplicationLoader to make the native_viewport_service run in the shell's main thread. BUG=484234 Committed: https://crrev.com/9b949563e5701642b723d980d2165639040cfc1c Cr-Commit-Position: refs/heads/master@{#330201}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+136 lines, -72 lines) Patch
M components/native_viewport/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M components/native_viewport/main.cc View 1 chunk +2 lines, -71 lines 0 comments Download
A components/native_viewport/native_viewport_application_delegate.h View 1 chunk +53 lines, -0 lines 0 comments Download
A components/native_viewport/native_viewport_application_delegate.cc View 1 chunk +61 lines, -0 lines 0 comments Download
M mandoline/app/core_services_initialization.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mandoline/services/core_services/BUILD.gn View 1 chunk +5 lines, -1 line 0 comments Download
M mandoline/services/core_services/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M mandoline/services/core_services/core_services_application_delegate.cc View 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Elliot Glaysher
At least on desktop builds, everything but html_viewer is part of one of the core ...
5 years, 7 months ago (2015-05-15 20:50:36 UTC) #2
Ben Goodger (Google)
On 2015/05/15 20:50:36, Elliot Glaysher wrote: > At least on desktop builds, everything but html_viewer ...
5 years, 7 months ago (2015-05-15 20:56:40 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1135703004/1
5 years, 7 months ago (2015-05-15 21:00:58 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-15 21:23:14 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-18 11:27:43 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b949563e5701642b723d980d2165639040cfc1c
Cr-Commit-Position: refs/heads/master@{#330201}

Powered by Google App Engine
This is Rietveld 408576698